Skip to content

Add olvr.pro / connect template#1187

Open
jakeduncan-tbd wants to merge 3 commits into
Domain-Connect:masterfrom
jakeduncan-tbd:olvr-connect
Open

Add olvr.pro / connect template#1187
jakeduncan-tbd wants to merge 3 commits into
Domain-Connect:masterfrom
jakeduncan-tbd:olvr-connect

Conversation

@jakeduncan-tbd

Copy link
Copy Markdown

Description

New Domain Connect template for olvr — connects a customer's subdomain to their olvr community via a single CNAME to our Cloudflare-for-SaaS origin (cname.olvr.pro), with automatic HTTPS.

Type of change

  • New template

How Has This Been Tested?

  • Template functionality checked using the Online Editor
  • Template file name follows the pattern <providerId>.<serviceId>.json
  • logoUrl served by a webserver — N/A, no logoUrl in this template

Checklist of common problems

  • syncPubKeyDomainnot set; justified: single static CNAME, no variables, no redirect_uri; points only to our fixed Cloudflare-for-SaaS origin (cname.olvr.pro). No signing key yet, so warnPhishing is used instead.
  • warnPhishing not set alongside syncPubKeyDomain
  • syncRedirectDomain — N/A, no redirect_uri
  • no TXT with SPF content — N/A, no TXT records
  • txtConflictMatchingMode — N/A, no TXT records
  • no bare variable as a full record value — N/A, no variables
  • no bare variable as a full host label — N/A, no variables
  • no variable in host for a subdomain — uses hostRequired + the host parameter
  • %host% not written explicitly
  • essential: OnApply where needed — N/A, single CNAME

Online Editor test results

Editor test link(s): Test olvr.pro/connect techead.lol/community

@github-actions github-actions Bot added hostRequired hostRequired is set no syncPubKeyDomain syncPubKeyDomain not set. Template is not secured. labels Jun 4, 2026
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

PR Description Check Passed

All required sections are filled in correctly.

Details
  OK  Type of change: 1/1 checkboxes ticked
  OK  How Has This Been Tested?: all 3 checkboxes ticked
  OK  Checklist of common problems: 9/10 checkboxes ticked
  OK  Online Editor test results: 1 link(s) found
  OK  Template coverage: all 1 template(s) covered
Labels to remove: Checklist of common problems not complete, Forged editor links, PR description incomplete, Test links missing

PR description check PASSED

@github-actions github-actions Bot added the warnPhishing warnPhishing is set. Template is not secured. label Jun 4, 2026
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

JSON Filename Check Passed

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

JSON Schema Validation Passed

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

Linter OK

olvr.pro.connect.json

Level Code Note
info DCTL1029 template does not have syncPubKeyDomain

Comment thread olvr.pro.connect.json
"serviceName": "Connect your domain to olvr",
"version": 1,
"description": "Connect a subdomain to your olvr community, with automatic HTTPS.",
"warnPhishing": true,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syncPubKeyDomain — not set; justified: single static CNAME, no variables, no redirect_uri; points only to our fixed Cloudflare-for-SaaS origin (cname.olvr.pro). No signing key yet, so warnPhishing is used instead.

Rather think of implementing signing to save you work on onboarding the template twice.

@pawel-kow pawel-kow added the review issues Changes requested from PR review label Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hostRequired hostRequired is set no syncPubKeyDomain syncPubKeyDomain not set. Template is not secured. review issues Changes requested from PR review warnPhishing warnPhishing is set. Template is not secured.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants