Add olvr.pro / connect template#1187
Open
jakeduncan-tbd wants to merge 3 commits into
Open
Conversation
PR Description Check PassedAll required sections are filled in correctly. Details |
|
✅ JSON Filename Check Passed |
|
✅ JSON Schema Validation Passed |
Linter OK
|
| Level | Code | Note |
|---|---|---|
| info | DCTL1029 | template does not have syncPubKeyDomain |
pawel-kow
requested changes
Jun 7, 2026
| "serviceName": "Connect your domain to olvr", | ||
| "version": 1, | ||
| "description": "Connect a subdomain to your olvr community, with automatic HTTPS.", | ||
| "warnPhishing": true, |
Member
There was a problem hiding this comment.
syncPubKeyDomain — not set; justified: single static CNAME, no variables, no redirect_uri; points only to our fixed Cloudflare-for-SaaS origin (cname.olvr.pro). No signing key yet, so warnPhishing is used instead.
Rather think of implementing signing to save you work on onboarding the template twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
New Domain Connect template for olvr — connects a customer's subdomain to their olvr community via a single CNAME to our Cloudflare-for-SaaS origin (cname.olvr.pro), with automatic HTTPS.
Type of change
How Has This Been Tested?
<providerId>.<serviceId>.jsonlogoUrlin this templateChecklist of common problems
syncPubKeyDomain— not set; justified: single static CNAME, no variables, noredirect_uri; points only to our fixed Cloudflare-for-SaaS origin (cname.olvr.pro). No signing key yet, sowarnPhishingis used instead.warnPhishingnot set alongsidesyncPubKeyDomainsyncRedirectDomain— N/A, noredirect_uritxtConflictMatchingMode— N/A, no TXT recordshostfor a subdomain — useshostRequired+ the host parameter%host%not written explicitlyessential: OnApplywhere needed — N/A, single CNAMEOnline Editor test results
Editor test link(s): Test olvr.pro/connect techead.lol/community