fix(commands): run parent command's after_invoke before invoking children - #1584
Open
shiftinv wants to merge 2 commits into
Open
fix(commands): run parent command's after_invoke before invoking children#1584shiftinv wants to merge 2 commits into
after_invoke before invoking children#1584shiftinv wants to merge 2 commits into
Conversation
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #893, supersedes #1192.
The issue in #893 is actually a side-effect of another bug - a parent slash command's
after_invokecurrently runs after the hooks and invokes of the group/sub command. This is unlike prefix commands, which are all self-containedbefore -> invoke -> aftersets for each group/command in the chain.Running the parent slash command's
after_invokelate then also meant thatInteraction.application_commandwas set to the subcommand, as its.prepare()had already run.I've marked this as a breaking change just to be on the safe side, though it shouldn't have a significant impact.
To maybe illustrate ths a bit better, consider a
rootcommand, with agroupsub command group, which has asubsub command -Checklist
uv run nox -s lintuv run nox -s pyright