fix(interactions): use previous flags value when editing messages - #1582
Merged
Conversation
…lags-attachment-editing # Conflicts: # disnake/interactions/base.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retains sent interaction response messages and uses that message's
flagsas the baseline when later editing the message usingInteractionResponse.edit_original_response. I would assume it's fairly rare to hit any issues with the current code, but something like this previously did not work:Setting
suppress_embedswould edit the message withflags: 128, which fails as the cv2 flag (32768) cannot be unset.As an added bonus, the code no longer has to fetch
.original_response()when adding new files in an edit.-Checklist
uv run nox -s lintuv run nox -s pyright