feat: provide api to customize server address#5473
Open
seflue wants to merge 1 commit into
Open
Conversation
seflue
force-pushed
the
feat/serve-with-address
branch
3 times, most recently
from
4f4db3c to
bbd7044
Compare
seflue
force-pushed
the
feat/serve-with-address
branch
2 times, most recently
from
f9bf068 to
7bc3284
Compare
Users who need to control the server address
programmatically are forced to use
std::env::set_var("PORT", ...), which is unsafe
in Rust edition 2024.
Adds serve_at(addr, cb) as a safe alternative.
serve() now delegates to it internally.
seflue
force-pushed
the
feat/serve-with-address
branch
from
7bc3284 to
1eeea20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5263
Before 0.7,
fullstack::Config::new().addr(...)allowed setting the server address programmatically. This was removed in the 0.7 refactoring, leavingIP/PORTenv vars as the only option. On Rust edition 2024, that means callingunsafe { std::env::set_var(...) }beforeserve().serve_atis a new entry point that takes aSocketAddrand a callback, which is just wrapped byserve(), so existing behavior is unchanged. It is re-exported asdioxus::serve_atand included in the prelude.