Skip to content

fix windows icon for browser #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicoburns merged 1 commit into from
May 5, 2026
+6 −2
Merged

fix windows icon for browser #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions apps/browser/Dioxus.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ android_main_activity = "MainActivity.kt"
[bundle]
publisher = "DioxusLabs"
identifier = "com.dioxuslabs.blitz"
icon = ["./assets/blitz-logo.png"]
icon = ["./assets/blitz-logo.png", "./assets/blitz-logo.ico"]

[bundle.windows]
webview_install_mode = "Skip"
icon_path = "assets\\blitz-logo.ico"
5 changes: 5 additions & 0 deletions apps/browser/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ use status_bar::StatusBar;
use tab::{Tab, TabId, TabStoreImplExt, TabWebView, active_tab, open_tab, tab_display_title};
use tab_strip::TabStrip;
use toolbar::Toolbar;
#[cfg(target_os = "windows")]
use winit::platform::windows::WinIcon;

static BROWSER_UI_STYLES: Asset = asset!("../assets/browser.css");
pub(crate) const IS_MOBILE: bool = cfg!(any(target_os = "android", target_os = "ios"));
Expand All @@ -56,6 +58,9 @@ fn main() {
#[cfg(feature = "tracing")]
tracing_subscriber::fmt::init();
let window_attributes = WindowAttributes::default();
#[cfg(target_os = "windows")]
let window_attributes = window_attributes
.with_window_icon(WinIcon::from_resource(32512, None).map(Into::into).ok());
#[cfg(target_os = "macos")]
let window_attributes = window_attributes.with_platform_attributes(Box::new(
WindowAttributesMacOS::default()
Expand Down
Loading