Skip to content

feat: Reduce logging noise #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dan-fernandes wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: Reduce logging noise #1576

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea676a5
Only log PUT and POST requests as info
dan-fernandes Jun 26, 2026
0d76cbb
Remove duplicate logs for GET requests
dan-fernandes Jun 26, 2026
e37c576
Merge branch 'main' into reduce-logging-noise
dan-fernandes Jun 26, 2026
a1d0ddc
Only log GET requests as debug, all else as info
dan-fernandes Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/blueapi/service/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,16 +594,19 @@ def start(config: ApplicationConfig):
async def log_request_details(
request: Request, call_next: Callable[[Request], Awaitable[StreamingResponse]]
) -> Response:
"""Middleware to log all request's host, method, path, status and request and
body"""
log = LOGGER.debug if request.url.path == "/healthz" else LOGGER.info
"""Middleware to log request's host, method, path, status and request and
body

Logs GET as debug, all else as info."""
log = LOGGER.debug if request.method == "GET" else LOGGER.info
request_body = await request.body()
client = request.client or Address("Unknown", -1)
log_message = f"{client.host}:{client.port} {request.method} {request.url.path}"
extra = {
"request_body": request_body,
}
log(log_message, extra=extra)
if request.method != "GET":
log(log_message, extra=extra)

response = await call_next(request)
log_message += f" {response.status_code}"
Expand Down
Loading