Skip to content
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions e2e/testcafe-devextreme/tests/dataGrid/common/pager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,41 @@ test('Page index should not reset when scrolling while the grid is being refresh
height: 440,
}));

test('Pager info should show page 1 of 1 after changing pageSize to \'all\' with virtual scrolling', async (t) => {
const dataGrid = new DataGrid('#container');
const pager = dataGrid.getPager();

await t
.click(pager.getNavPage('5').element)
.expect(pager.getNavPage('5').selected)
.ok()
.expect(pager.getInfoText().textContent)
.eql('Page 5 of 10 (50 items)');

await t
.click(pager.getPageSize(1).element)
.expect(pager.getInfoText().textContent)
.eql('Page 1 of 1 (50 items)');
}).before(async () => createWidget('dxDataGrid', {
dataSource: [...new Array(50).keys()].map((i) => ({ id: i })),
keyExpr: 'id',
showBorders: true,
scrolling: {
mode: 'virtual',
},
paging: {
pageSize: 5,
},
pager: {
visible: true,
allowedPageSizes: [5, 'all'],
showPageSizeSelector: true,
showInfo: true,
showNavigationButtons: true,
},
height: 400,
}));

test('No error should occur if dataSource is not defined and pageIndex is promise chained (T1256070)', async (t) => {
const dataGrid = new DataGrid('#container');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ const PAGER_CLASS = 'pager';
export const MAX_PAGES_COUNT = 10;

const getPageIndex = function (dataController) {
Comment thread
Tucchhaa marked this conversation as resolved.
if (dataController.pageSize() === 0) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lines may confuse later, I think it should be fixed on pageIndex level instead
like changePaging in data controller resets pageIndex to 0 in case of pageSize = 0, same should be here, also you may notice that after changing to pageSize = All grid shows 1st page (rows from 1), not keeps the prev one

return dataController.pageCount();
}

// eslint-disable-next-line radix
return 1 + (parseInt(dataController.pageIndex()) || 0);
};
Expand Down
Loading