Skip to content

Multi-Sided Sign Support #2796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MC-Samuel wants to merge 14 commits into
base: dev
Choose a base branch
from
Open

Multi-Sided Sign Support #2796

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
cf3b3ba
Added SignContentsBack ItemTag property and LocationTag tag and mecha…
MC-Samuel Dec 1, 2025
ab8f8d7
slight corrections
MC-Samuel Dec 1, 2025
0f2a237
one more
MC-Samuel Dec 1, 2025
f0b904b
slight adjustments
MC-Samuel Dec 1, 2025
d7f7b5a
Merge branch 'dev' into sign_back
MC-Samuel Jan 14, 2026
052f456
meta removal fix from merge
MC-Samuel Jan 14, 2026
9cf0e07
meta fix from original pr implementation
MC-Samuel Jan 14, 2026
d46b6a8
added back-of-sign glowing and glow color tags and mechanisms
MC-Samuel Jan 14, 2026
4c8310e
minor changes
MC-Samuel Jan 18, 2026
055ac88
renamed `sign_x_back` usages to `sign_back_x`
MC-Samuel Mar 2, 2026
fa34e12
missed one
MC-Samuel Mar 2, 2026
2184381
meta clarification
MC-Samuel Mar 2, 2026
8a1f43d
minor changes
MC-Samuel Apr 25, 2026
c703bd1
fixes
MC-Samuel Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions paper/src/main/java/com/denizenscript/denizen/paper/utilities/PaperAPIToolsImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import net.md_5.bungee.api.chat.BaseComponent;
import org.bukkit.*;
import org.bukkit.block.Sign;
import org.bukkit.block.sign.Side;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.*;
import org.bukkit.event.entity.CreatureSpawnEvent;
Expand Down Expand Up @@ -104,15 +105,36 @@ public String getPlayerListName(Player player) {
public String[] getSignLines(Sign sign) {
String[] output = new String[4];
int i = 0;
for (Component component : sign.lines()) {
List<Component> list = NMSHandler.getVersion().isAtLeast(NMSVersion.v1_20) ? sign.getSide(Side.FRONT).lines() : sign.lines();
for (Component component : list) {
output[i++] = PaperModule.stringifyComponent(component);
}
return output;
}

@Override
public String[] getBackSignLines(Sign sign) {
String[] output = new String[4];
int i = 0;
for (Component component : sign.getSide(Side.BACK).lines()) {
output[i++] = PaperModule.stringifyComponent(component);
}
return output;
}
Copy link
Copy Markdown
Member

@tal5 tal5 Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that there's two of these, a util method for the List<Component> -> String[] operation would be nice, as both methods are essentially the same


@Override
public void setSignLine(Sign sign, int line, String text) {
sign.line(line, PaperModule.parseFormattedText(text == null ? "" : text, ChatColor.BLACK));
if (NMSHandler.getVersion().isAtLeast(NMSVersion.v1_20)) {
sign.getSide(Side.FRONT).line(line, PaperModule.parseFormattedText(text == null ? "" : text, ChatColor.BLACK));
}
else {
sign.line(line, PaperModule.parseFormattedText(text == null ? "" : text, ChatColor.BLACK));
}
}

@Override
public void setBackSignLine(Sign sign, int line, String text) {
sign.getSide(Side.BACK).line(line, PaperModule.parseFormattedText(text == null ? "" : text, ChatColor.BLACK));
}

@Override
Expand Down
Loading