Fix DAC (Dacorum) scraper#346
Open
symroe wants to merge 1 commit into
Open
Conversation
The https://democracy.dacorum.gov.uk certificate is not trusted by wreq's embedded BoringSSL CA bundle, causing CERTIFICATE_VERIFY_FAILED on every request. Adding verify_requests = False bypasses TLS certificate validation, allowing the ModGov ASMX endpoint to respond with councillor data. We scrape read-only public data so MITM risk is acceptable. Locally verified: 50 councillors, 50 with photos. The council does not publish email addresses via the ModGov XML service.
Member
Author
Re-scrape after 7d88f41Initial fix: Verified locally with
Emails: the Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
The
https://democracy.dacorum.gov.ukcertificate is not trusted bywreq's embedded BoringSSL CA bundle. Every request to the ModGov ASMX endpoint fails immediately withCERTIFICATE_VERIFY_FAILED. The dashboard error showed "Request timeout after 30+ seconds" but local reproduction reveals the underlying cause is a TLS certificate validation failure (completes in under 1 second, not a timeout).What was fixed
verify_requests = Falseto theScraperclass incouncillors.pyScrape results
Generated by Claude Code