fixed bug#1448: made VtmnSelect React component to show label only when labelText prop is passed to it#1495
Open
rajeshpoojari39 wants to merge 1 commit intoDecathlon:mainfrom
Open
fixed bug#1448: made VtmnSelect React component to show label only when labelText prop is passed to it#1495rajeshpoojari39 wants to merge 1 commit intoDecathlon:mainfrom
rajeshpoojari39 wants to merge 1 commit intoDecathlon:mainfrom
Conversation
…en labelText prop is passed to it
|
|
lauthieb
force-pushed
the
main
branch
5 times, most recently
from
661d59e to
6f7e7f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes description
Made changes to VtmnSelect React component to show label only when labelText prop is passed to it.
Context
The issue mentioned in the below link says the VtmnSelect component shows label html tag when empty label is passed to the component. I have made fix for this in the VtmnSelect React component only, as I am well versed with react. With this fix the component will not add empty label html tag if labelText prop is not passed to it.
#1448
Checklist
design-system-core-team-designGitHub team.Does this introduce a breaking change?
Other information
This issue is only fixed for VtmnSelect React component