Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions bin/agent-data-plane/src/components/tag_filterlist/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -169,14 +169,16 @@ impl TransformBuilder for TagFilterlistConfiguration {

async fn build(&self, context: ComponentContext) -> Result<Box<dyn Transform + Send>, GenericError> {
let metrics_builder = MetricsBuilder::from_component_context(&context);
let telemetry = Telemetry::new(&metrics_builder);
telemetry.set_rules_loaded(self.entries.len());

Ok(Box::new(TagFilterlist {
filters: compile_filters(&self.entries),
configuration: self
.configuration
.clone()
.expect("configuration must be set via from_configuration"),
telemetry: Telemetry::new(&metrics_builder),
telemetry,
context_cache: build_context_cache(),
}))
}
Expand Down Expand Up @@ -265,9 +267,11 @@ impl Transform for TagFilterlist {
None => break,
},
(_, new_entries) = watcher.changed::<Vec<MetricTagFilterEntry>>() => {
self.filters = compile_filters(new_entries.as_deref().unwrap_or(&[]));
let entries = new_entries.as_deref().unwrap_or(&[]);
self.filters = compile_filters(entries);
self.context_cache = build_context_cache();
debug!("Updated metric tag filterlist.");
self.telemetry.set_rules_loaded(entries.len());
debug!(rules_loaded = entries.len(), "Updated metric tag filterlist.");
},
}
}
Expand Down
17 changes: 14 additions & 3 deletions bin/agent-data-plane/src/components/tag_filterlist/telemetry.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use metrics::Counter;
use metrics::{Counter, Gauge};
use saluki_metrics::MetricsBuilder;

use super::FilterMetricTagsOutcome;
Expand All @@ -10,17 +10,21 @@ pub struct Telemetry {
noop_hits: Counter,
metrics_modified: Counter,
tags_filtered: Counter,
rules_loaded: Gauge,
}

impl Telemetry {
pub fn new(builder: &MetricsBuilder) -> Self {
Self {
let me = Self {
rule_hits: builder.register_debug_counter("tag_filterlist_rule_hits_total"),
rule_misses: builder.register_debug_counter("tag_filterlist_rule_misses_total"),
noop_hits: builder.register_debug_counter("tag_filterlist_noop_hits_total"),
metrics_modified: builder.register_debug_counter("tag_filterlist_metrics_modified_total"),
tags_filtered: builder.register_debug_counter("tag_filterlist_tags_filtered_total"),
}
rules_loaded: builder.register_debug_gauge("tag_filterlist_rules_loaded"),
};
me.rules_loaded.set(0.0);
me
}

pub fn record(&self, outcome: FilterMetricTagsOutcome) {
Expand All @@ -39,4 +43,11 @@ impl Telemetry {
}
}
}

/// Records the number of tag filter rules currently loaded by the
/// transform. Called whenever the configuration is refreshed (initial
/// build or `metric_tag_filterlist` Remote Config update).
pub fn set_rules_loaded(&self, count: usize) {
self.rules_loaded.set(count as f64);
}
}
Loading