Allow dumping shm data directly for inspection#3829
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 196e70c2f3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (rc_json && rc_json[0]) { | ||
| zend_string *json_str = zend_string_init(rc_json, strlen(rc_json), 0); | ||
| if (zai_json_decode_assoc_safe(return_value, ZSTR_VAL(json_str), (int)ZSTR_LEN(json_str), 128, false) != SUCCESS) { | ||
| array_init(return_value); | ||
| } | ||
| zend_string_release(json_str); | ||
| ddog_remote_config_loaded_configs_free(rc_json); | ||
| } else { | ||
| array_init(return_value); |
There was a problem hiding this comment.
When no remote configs are loaded, ddog_remote_config_get_loaded_configs() still returns an allocated empty C string (""), but this branch initializes an empty PHP array without calling ddog_remote_config_loaded_configs_free(). In polling/debug scenarios (including this test pattern), repeated calls leak one Rust-allocated buffer per call. Please free rc_json whenever it is non-null, regardless of whether rc_json[0] is set.
Useful? React with 👍 / 👎.
| if (info_json && info_json[0]) { | ||
| zend_string *json_str = zend_string_init(info_json, strlen(info_json), 0); | ||
| if (zai_json_decode_assoc_safe(return_value, ZSTR_VAL(json_str), (int)ZSTR_LEN(json_str), 128, false) != SUCCESS) { | ||
| array_init(return_value); | ||
| } | ||
| zend_string_release(json_str); | ||
| ddog_agent_info_json_free(info_json); | ||
| } else { | ||
| array_init(return_value); |
There was a problem hiding this comment.
The same ownership issue appears in the agent-info helper: ddog_agent_info_as_json() allocates and returns an empty C string when no info is available, but the else path here skips ddog_agent_info_json_free(). If callers invoke dd_trace_internal_fn('get_agent_info') before SHM data is populated, this leaks memory on each call.
Useful? React with 👍 / 👎.
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: faa165b | Docs | Datadog PR Page | Give us feedback! |
Benchmarks [ tracer ]Benchmark execution time: 2026-04-24 18:24:36 Comparing candidate commit faa165b in PR branch Found 3 performance improvements and 0 performance regressions! Performance is the same for 191 metrics, 0 unstable metrics. scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache
scenario:MessagePackSerializationBench/benchMessagePackSerialization
scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
|
1 participant
This allows directly inspecting and analyzing the contents of data stored in SHM for debugging/testing purposes.