ci: fix exit 75 retry with FF_ENABLE_BASH_EXIT_CODE_CHECK and FF_USE_NEW_BASH_EVAL_STRATEGY

[Leiyks]

Root cause

GitLab Runner does not reliably propagate exit codes from external shell scripts (like wait-for-service-ready.sh) to the job's exit code. Without the fix, a before_script calling .gitlab/wait-for-service-ready.sh that exits 75 would be seen by the runner as exit code 1, so retry: exit_codes: [75] never matched and kafka jobs were never retried on transient infra failures.

This is addressed by two official GitLab Runner feature flags (both disabled by default):

• FF_ENABLE_BASH_EXIT_CODE_CHECK: check exit code after each command rather than relying solely on set -e
• FF_USE_NEW_BASH_EVAL_STRATEGY: run the bash eval call in a subshell for proper exit code detection

Fix

• generate-common.php: enable both feature flags globally via a top-level variables: block so all generated child pipelines inherit them
• generate-common.php: keep exit_codes: [75] in the default: retry block (confirmed working once exit codes propagate correctly)
• generate-tracer.php: remove all explicit per-job/per-template retry_on_infra_failure() and retry_on_script_and_infra_failure() overrides — default: handles everything

Side effect fix

FF_ENABLE_BASH_EXIT_CODE_CHECK adds an explicit exit code check after every YAML script step. This broke command -v switch-php && switch-php in generate-profiler.php: when switch-php is absent, command -v exits 1, the && short-circuits, and the runner treats the non-zero exit as a job failure — even though the intent was "run only if present".

Fixed by rewriting as if command -v switch-php > /dev/null 2>&1; then switch-php ...; fi, whose false branch always exits 0.

Validation

Confirmed with live CI runs:

• Jobs exiting 1 are not retried
• Jobs exiting 75 (via wait-for-service-ready.sh) are retried

[datadog-official]

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 60.64% (-0.04%)

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0d71df6 | Docs | Datadog PR Page | Give us feedback!}