Skip to content

Fix duration of httpstream and live debugger spans#3821

Merged
bwoebi merged 1 commit intomasterfrom
bob/span-time
Apr 24, 2026
Merged

Fix duration of httpstream and live debugger spans#3821
bwoebi merged 1 commit intomasterfrom
bob/span-time

Conversation

@bwoebi
Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi commented Apr 23, 2026

Yep, these had a duration of 0...

@bwoebi bwoebi requested a review from a team as a code owner April 23, 2026 16:36
@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented Apr 23, 2026

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.64% (-0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 63fee31 | Docs | Datadog PR Page | Give us feedback!

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 23, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-04-23 17:53:53

Comparing candidate commit 63fee31 in PR branch bob/span-time with baseline commit b7eb412 in branch master.

Found 1 performance improvements and 2 performance regressions! Performance is the same for 189 metrics, 2 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-5.293µs; -3.587µs] or [-4.675%; -3.168%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+53.930ns; +115.270ns] or [+3.674%; +7.854%]

scenario:SpanBench/benchDatadogAPI

  • 🟥 execution_time [+1.465µs; +3.091µs] or [+2.246%; +4.740%]

@bwoebi bwoebi merged commit 96c5f06 into master Apr 24, 2026
1908 of 1933 checks passed
@bwoebi bwoebi deleted the bob/span-time branch April 24, 2026 11:09
@github-actions github-actions Bot added this to the 1.19.0 milestone Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants