Skip to content

Flush telemetry as well on anticipated sidecar shutdown#3806

Merged
bwoebi merged 1 commit intomasterfrom
bob/telemetry-flush
Apr 22, 2026
Merged

Flush telemetry as well on anticipated sidecar shutdown#3806
bwoebi merged 1 commit intomasterfrom
bob/telemetry-flush

Conversation

@bwoebi
Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi commented Apr 20, 2026

Otherwise telemetry might not end up flushed for shortlived sidecars.

@bwoebi bwoebi requested review from a team as code owners April 20, 2026 19:20
@bwoebi bwoebi force-pushed the bob/telemetry-flush branch 2 times, most recently from 6c60335 to 59a58ef Compare April 21, 2026 18:39
@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented Apr 21, 2026

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.66% (+0.02%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 3ef666c | Docs | Datadog PR Page | Give us feedback!

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 21, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-04-22 16:17:06

Comparing candidate commit 3ef666c in PR branch bob/telemetry-flush with baseline commit 3df62fd in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 192 metrics, 1 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-6.618µs; -4.502µs] or [-6.144%; -4.181%]

@bwoebi bwoebi force-pushed the bob/telemetry-flush branch from 59a58ef to 3ef666c Compare April 22, 2026 14:56
@bwoebi bwoebi merged commit 4feb951 into master Apr 22, 2026
2097 of 2099 checks passed
@bwoebi bwoebi deleted the bob/telemetry-flush branch April 22, 2026 18:32
@github-actions github-actions Bot added this to the 1.19.0 milestone Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants