Skip to content

Further helper rust fixes#3803

Draft
cataphract wants to merge 4 commits intomasterfrom
glopes/further-helper-rust-fixes
Draft

Further helper rust fixes#3803
cataphract wants to merge 4 commits intomasterfrom
glopes/further-helper-rust-fixes

Conversation

@cataphract
Copy link
Copy Markdown
Contributor

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@cataphract cataphract requested a review from a team as a code owner April 16, 2026 16:18
@cataphract cataphract marked this pull request as draft April 16, 2026 16:18
@datadog-official
Copy link
Copy Markdown

datadog-official bot commented Apr 16, 2026

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.65% (-0.03%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7f667c9 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

This could result in telemetry metrics not being submitted if a certain
telemetry client was not active for more than half an hour (could happen
if the activity is very low).

It would also cause unnecessary (but o/wise benign) metric
registrations.
@cataphract cataphract force-pushed the glopes/further-helper-rust-fixes branch from 0623c3c to 7f667c9 Compare April 17, 2026 16:30
@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Apr 17, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-04-17 17:47:49

Comparing candidate commit 7f667c9 in PR branch glopes/further-helper-rust-fixes with baseline commit 217c346 in branch master.

Found 2 performance improvements and 2 performance regressions! Performance is the same for 189 metrics, 1 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache

  • 🟩 execution_time [-1426.724ns; -373.276ns] or [-8.492%; -2.222%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-3.135µs; -2.225µs] or [-2.974%; -2.110%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

  • 🟥 execution_time [+74.015ns; +160.785ns] or [+5.165%; +11.220%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+51.790ns; +154.810ns] or [+3.530%; +10.551%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant