Merged
Conversation
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 78a9328 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
bm1549
reviewed
Apr 15, 2026
Contributor
bm1549
left a comment
bm1549
left a comment
There was a problem hiding this comment.
LGTM assuming system tests pass!
Benchmarks [ tracer ]Benchmark execution time: 2026-04-15 22:08:14 Comparing candidate commit 78a9328 in PR branch Found 3 performance improvements and 0 performance regressions! Performance is the same for 190 metrics, 1 unstable metrics. scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:SamplingRuleMatchingBench/benchRegexMatching2
scenario:SamplingRuleMatchingBench/benchRegexMatching3
|
bwoebi
force-pushed
the
bob/fix-ksr
branch
2 times, most recently
from
141ceaf to
448243a
Compare
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Leiyks
approved these changes
Apr 16, 2026
|
Thank you @bwoebi & reviewers for the bug fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3796.