Skip to content
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitlab/generate-package.php
Original file line number Diff line number Diff line change
Expand Up @@ -1236,7 +1236,7 @@
pip install -U pip virtualenv
<?php dockerhub_login() ?>
- /tmp/vault kv get --format=json "kv/k8s/gitlab-runner/dd-trace-php/datadoghq-api-key" 2>/dev/null | python3 -c "import sys,json;print(json.load(sys.stdin)['data']['data']['key'])" > /tmp/.dd-api-key 2>/dev/null || true
- git clone https://github.com/DataDog/system-tests.git
- git clone --branch maxim/fix-php-config-tests-use-library-interface https://github.com/DataDog/system-tests.git
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Revert temporary system-tests branch pin

This change makes CI clone DataDog/system-tests from maxim/fix-php-config-tests-use-library-interface instead of the default stable branch, so merged pipelines will depend on a personal feature branch rather than upstream system-tests. That means routine System Tests runs no longer validate the canonical suite and can fail immediately if the feature branch is renamed, force-pushed, or removed.

Useful? React with 👍 / 👎.

- mv packages/{datadog-setup.php,dd-library-php-*x86_64-linux-gnu.tar.gz} system-tests/binaries
- cd system-tests
- ./build.sh $BUILD_SH_ARGS
Expand Down
Loading