Merged
Conversation
Benchmarks [ tracer ]Benchmark execution time: 2025-08-05 21:44:54 Comparing candidate commit e1e9649 in PR branch Found 1 performance improvements and 2 performance regressions! Performance is the same for 175 metrics, 0 unstable metrics. scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:PDOBench/benchPDOBaseline
scenario:TraceSerializationBench/benchSerializeTrace
|
morrisonlevi
reviewed
Aug 1, 2025
| // Generally the Send buffer ought to be big enough for instantaneous transmission | ||
| _ = stream.set_write_timeout(Some(Duration::from_millis(100))); | ||
| _ = stream.set_read_timeout(Some(Duration::from_secs(10))); | ||
| // We do not put reconnect_fn into sidecar_connect, as the reconnect shall not reconnect again on error to prevent recursion |
This now reconnects immediately, gracefully restoring telemetry and remote config state (i.e. resending service / env etc. tags), making sure the queue_id exists on the sidecar side. This should avoid significant data loss scenarios and infinite broken pipe loops. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi
force-pushed
the
bob/sidecar-reconnect
branch
from
72eef1e to
5075b3c
Compare
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3370 +/- ##
==========================================
- Coverage 61.95% 61.82% -0.13%
==========================================
Files 140 140
Lines 12388 12388
Branches 1622 1622
==========================================
- Hits 7675 7659 -16
- Misses 3999 4015 +16
Partials 714 714 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This now reconnects immediately, gracefully restoring telemetry and remote config state (i.e. resending service / env etc. tags), making sure the queue_id exists on the sidecar side.
This should avoid significant data loss scenarios and infinite broken pipe loops.