Skip to content

Commit f2c60b4

Browse files
committed
feat(benchmarks): add PHP parallel benchmarks via apm-sdks-benchmarks include
Switch from a trigger job to a GitLab CI include, pulling the PHP Laravel Realworld parallel benchmark jobs directly into this pipeline. Adds two new stages: php-laravel-realworld-parallel and php-laravel-realworld-parallel-slo.
1 parent 8ba315d commit f2c60b4

File tree

1 file changed

+7
-18
lines changed

1 file changed

+7
-18
lines changed

.gitlab/benchmarks.yml

Lines changed: 7 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,13 @@ include:
33
file: 'images/templates/gitlab/check-slo-breaches.template.yml'
44
- project: 'DataDog/benchmarking-platform-tools'
55
file: 'images/templates/gitlab/notify-slo-breaches.template.yml'
6+
- project: 'DataDog/apm-reliability/apm-sdks-benchmarks'
7+
file: '.gitlab/ci-php-laravel-realworld-parallel.yml'
8+
ref: 'main'
9+
10+
stages:
11+
- php-laravel-realworld-parallel
12+
- php-laravel-realworld-parallel-slo
613

714
variables:
815
BASE_CI_IMAGE: 486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/benchmarking-platform:dd-trace-php-82-dev
@@ -258,21 +265,3 @@ notify-slo-breaches:
258265
rules: *pre-release-performance-quality-gates-rules
259266
variables:
260267
CHANNEL: "guild-dd-php"
261-
262-
apm-sdk-benchmarks:
263-
stage: benchmarks
264-
when: manual
265-
allow_failure: true
266-
# No `needs:` here — unlike dd-trace-py which uploads per-pipeline wheels to
267-
# S3 (keyed by CI_PIPELINE_ID), dd-trace-php publishes to S3 keyed by VERSION
268-
# string only. The apm-sdks-benchmarks fetch script downloads the latest
269-
# GitHub release instead of a specific pipeline build.
270-
trigger:
271-
project: DataDog/apm-reliability/apm-sdks-benchmarks
272-
branch: main
273-
variables:
274-
# PARENT_PIPELINE_ID (not CI_PIPELINE_ID): benchmarks.yml runs as a child
275-
# pipeline, so CI_PIPELINE_ID here is the child pipeline ID. PARENT_PIPELINE_ID
276-
# is explicitly forwarded from the parent pipeline in .gitlab-ci.yml and
277-
# identifies the main dd-trace-php pipeline that triggered this run.
278-
TARGET_REF: $PARENT_PIPELINE_ID

0 commit comments

Comments
 (0)