Skip to content

Commit 8ba315d

Browse files
committed
feat(benchmarks): add apm-sdk-benchmarks trigger for PHP competitor benchmarks (LANGPLAT-883)
Adds a manual trigger job in the benchmarks child pipeline that launches the PHP competitor benchmark in DataDog/apm-reliability/apm-sdks-benchmarks. Key differences from dd-trace-py's apm-sdk-benchmarks job: - No `needs:` prerequisite: dd-trace-php has no per-pipeline S3 upload (unlike dd-trace-py which uploads wheels keyed by CI_PIPELINE_ID). The apm-sdks-benchmarks fetch script uses the latest GitHub release. - Uses TARGET_REF: $PARENT_PIPELINE_ID (not CI_PIPELINE_ID): benchmarks.yml is a child pipeline, so CI_PIPELINE_ID is the child ID. PARENT_PIPELINE_ID is forwarded from .gitlab-ci.yml and identifies the main pipeline.
1 parent 2b97a2a commit 8ba315d

File tree

1 file changed

+18
-0
lines changed

1 file changed

+18
-0
lines changed

.gitlab/benchmarks.yml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -258,3 +258,21 @@ notify-slo-breaches:
258258
rules: *pre-release-performance-quality-gates-rules
259259
variables:
260260
CHANNEL: "guild-dd-php"
261+
262+
apm-sdk-benchmarks:
263+
stage: benchmarks
264+
when: manual
265+
allow_failure: true
266+
# No `needs:` here — unlike dd-trace-py which uploads per-pipeline wheels to
267+
# S3 (keyed by CI_PIPELINE_ID), dd-trace-php publishes to S3 keyed by VERSION
268+
# string only. The apm-sdks-benchmarks fetch script downloads the latest
269+
# GitHub release instead of a specific pipeline build.
270+
trigger:
271+
project: DataDog/apm-reliability/apm-sdks-benchmarks
272+
branch: main
273+
variables:
274+
# PARENT_PIPELINE_ID (not CI_PIPELINE_ID): benchmarks.yml runs as a child
275+
# pipeline, so CI_PIPELINE_ID here is the child pipeline ID. PARENT_PIPELINE_ID
276+
# is explicitly forwarded from the parent pipeline in .gitlab-ci.yml and
277+
# identifies the main dd-trace-php pipeline that triggered this run.
278+
TARGET_REF: $PARENT_PIPELINE_ID

0 commit comments

Comments
 (0)