Skip to content

Add FFE SDK owners to flag module - #2988

Merged
leoromanovsky merged 2 commits into
developfrom
codex/feature-flags-codeowners
Jul 2, 2026
Merged

Add FFE SDK owners to flag module#2988
leoromanovsky merged 2 commits into
developfrom
codex/feature-flags-codeowners

Conversation

@leoromanovsky

@leoromanovsky leoromanovsky commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Motivation

FFE SDK engineers should be requested on changes to the iOS feature flag SDK module.

Changes

  • Add @DataDog/feature-flagging-and-experimentation-sdk as a CODEOWNER for /DatadogFlags/.
  • Keep the existing RUM mobile and iOS mobile owners on that module.

Decisions

  • Targeted develop because this repository does not have a main branch.
  • No runtime tests were run; this is a CODEOWNERS-only change. Validated with git diff --check.

@leoromanovsky
leoromanovsky marked this pull request as ready for review June 11, 2026 04:39
@leoromanovsky
leoromanovsky requested review from a team as code owners June 11, 2026 04:39
@dd-octo-sts-c33ac5

dd-octo-sts-c33ac5 Bot commented Jun 11, 2026

Copy link
Copy Markdown

🐑 PR Shepherd is maintaining this PR

I watch your PR and automatically fix CI failures, rebase your branch, handle flaky tests, and push it to the merge queue when it's ready.

More about what I do → Guide

To pause me on this PR, add the flow-skip label.

@leoromanovsky
leoromanovsky requested a review from sameerank June 11, 2026 04:40

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aadff98ea1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/CODEOWNERS Outdated

## Feature Flags

/DatadogFlags/ @DataDog/rum-mobile @DataDog/rum-mobile-ios @DataDog/feature-flags-sdks

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include the Flags podspec in ownership

When a PR changes only DatadogFlags.podspec, the new Feature Flags owners will not be requested because this CODEOWNERS pattern only covers files under the DatadogFlags/ directory. The podspec is the CocoaPods packaging definition for this module (s.name = "DatadogFlags" and s.source_files = "DatadogFlags/Sources/**/*.swift"), so changes there can affect Flags consumers without review from @DataDog/feature-flags-sdks; add a separate root-level pattern for the podspec if these owners should cover the full module.

Useful? React with 👍 / 👎.

maxep
maxep previously approved these changes Jun 18, 2026
@dd-octo-sts-98cdbc

Copy link
Copy Markdown

👋 This PR is now being monitored by PR Shepherd.

It watches CI and the merge queue and helps the PR move toward merge — rebasing onto the base branch when it falls behind and re-queueing after a transient merge-queue failure.

Read more about PR shepherd hereNeed a hand? Reach the team in #ai-devx-flow. To opt out, add the flow-skip label.

@mikewoo-dd

Copy link
Copy Markdown

Please disregard comment from PR shepherd above. We're doing a dry run test and would not make any change to the PR.

maycmlee
maycmlee previously approved these changes Jun 29, 2026
sameerank
sameerank previously approved these changes Jun 29, 2026
@leoromanovsky
leoromanovsky dismissed stale reviews from sameerank, maycmlee, and maxep via d1c09c6 June 29, 2026 15:10
@leoromanovsky

Copy link
Copy Markdown
Contributor Author

Sorry folks, I had the wrong GitHub team (mosaic versus ffe): d1c09c6

@leoromanovsky
leoromanovsky merged commit f34793a into develop Jul 2, 2026
3 checks passed
@leoromanovsky
leoromanovsky deleted the codex/feature-flags-codeowners branch July 2, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants