Add FFE SDK owners to flag module - #2988
Conversation
🐑 PR Shepherd is maintaining this PRI watch your PR and automatically fix CI failures, rebase your branch, handle flaky tests, and push it to the merge queue when it's ready. More about what I do → Guide To pause me on this PR, add the |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aadff98ea1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ## Feature Flags | ||
|
|
||
| /DatadogFlags/ @DataDog/rum-mobile @DataDog/rum-mobile-ios @DataDog/feature-flags-sdks |
There was a problem hiding this comment.
Include the Flags podspec in ownership
When a PR changes only DatadogFlags.podspec, the new Feature Flags owners will not be requested because this CODEOWNERS pattern only covers files under the DatadogFlags/ directory. The podspec is the CocoaPods packaging definition for this module (s.name = "DatadogFlags" and s.source_files = "DatadogFlags/Sources/**/*.swift"), so changes there can affect Flags consumers without review from @DataDog/feature-flags-sdks; add a separate root-level pattern for the podspec if these owners should cover the full module.
Useful? React with 👍 / 👎.
|
👋 This PR is now being monitored by PR Shepherd. It watches CI and the merge queue and helps the PR move toward merge — rebasing onto the base branch when it falls behind and re-queueing after a transient merge-queue failure. Read more about PR shepherd hereNeed a hand? Reach the team in #ai-devx-flow. To opt out, add the |
|
Please disregard comment from PR shepherd above. We're doing a dry run test and would not make any change to the PR. |
d1c09c6
|
Sorry folks, I had the wrong GitHub team (mosaic versus ffe): d1c09c6 |
Motivation
FFE SDK engineers should be requested on changes to the iOS feature flag SDK module.
Changes
@DataDog/feature-flagging-and-experimentation-sdkas a CODEOWNER for/DatadogFlags/.Decisions
developbecause this repository does not have amainbranch.git diff --check.