[chain-pr 9/10] DatadogSessionReplay and DatadogWebViewTracking: typed-bus migration#2935
Draft
maxep wants to merge 1 commit into
Draft
Conversation
|
maxep
force-pushed
the
maxep/message-bus-subscription--chain-8
branch
from
bacef42 to
f8cc071
Compare
maxep
force-pushed
the
maxep/message-bus-subscription--chain-9
branch
from
d3a12bb to
3f5008f
Compare
maxep
force-pushed
the
maxep/message-bus-subscription--chain-8
branch
from
f8cc071 to
a5e626c
Compare
maxep
force-pushed
the
maxep/message-bus-subscription--chain-9
branch
from
3f5008f to
0eaba29
Compare
maxep
force-pushed
the
maxep/message-bus-subscription--chain-8
branch
from
a5e626c to
f540649
Compare
maxep
force-pushed
the
maxep/message-bus-subscription--chain-9
branch
from
0eaba29 to
6bb4f48
Compare
5 tasks
maxep
force-pushed
the
maxep/message-bus-subscription--chain-8
branch
from
f540649 to
a938556
Compare
maxep
force-pushed
the
maxep/message-bus-subscription--chain-9
branch
from
6bb4f48 to
2dd53eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Migrates Session Replay's RUMContextReceiver and WebViewRecordReceiver to BusMessageReceiver, restructures RecordingComponents to expose the typed context receiver, wires subscriptions in SessionReplay.enable, and migrates WebViewTracking's MessageEmitter to send typed WebView bus messages. Updates tests.
Refactoring rationale
Session Replay's receivers move to typed BusMessageReceiver, splitting the previous CombinedFeatureMessageReceiver into independent subscriptions. WebViewTracking now publishes typed WebViewLogMessage/WebViewRUMMessage/WebViewRecordMessage instead of the .webview FeatureMessage envelope, matching the consumer side (Logs/RUM/SR) already migrated in earlier groups.
Draft — pending author review. Merge in order unless marked parallel.