[chain-pr 8/10] DatadogRUM: typed-bus migration and TelemetryInterceptor merge#2934
Draft
maxep wants to merge 1 commit into
Draft
Conversation
|
maxep
force-pushed
the
maxep/message-bus-subscription--chain-7
branch
from
185b00a to
f54b5ec
Compare
maxep
force-pushed
the
maxep/message-bus-subscription--chain-8
branch
from
bacef42 to
f8cc071
Compare
maxep
force-pushed
the
maxep/message-bus-subscription--chain-7
branch
from
f54b5ec to
c97dbac
Compare
maxep
force-pushed
the
maxep/message-bus-subscription--chain-8
branch
from
f8cc071 to
a5e626c
Compare
maxep
force-pushed
the
maxep/message-bus-subscription--chain-7
branch
from
c97dbac to
2f2ffbc
Compare
maxep
force-pushed
the
maxep/message-bus-subscription--chain-8
branch
from
a5e626c to
f540649
Compare
5 tasks
maxep
force-pushed
the
maxep/message-bus-subscription--chain-7
branch
from
2f2ffbc to
176b9f2
Compare
maxep
force-pushed
the
maxep/message-bus-subscription--chain-8
branch
from
f540649 to
a938556
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Migrates all RUM receivers (CrashReportReceiver, ErrorMessageReceiver, FlagEvaluationReceiver, TelemetryReceiver, WebViewEventReceiver, WatchdogTerminationMonitor) to BusMessageReceiver, merges TelemetryInterceptor responsibilities into TelemetryReceiver, switches FatalErrorContextNotifier to MessageBus, and subscribes receivers in RUM.enable. Deletes the obsolete TelemetryInterceptor and its tests, and updates RUM tests/mocks.
Refactoring rationale
RUM's CombinedFeatureMessageReceiver short-circuit chain is replaced with independent typed subscribers. TelemetryInterceptor — previously a side-receiver in the chain that captured SDK errors and upload-quality metrics — is folded into TelemetryReceiver, which now owns the SessionEndedMetricController hook and intercepts upload-quality metrics before forwarding. FatalErrorContextNotifier moves from MessageSending to the typed MessageBus protocol to align with the rest of the feature.
Draft — pending author review. Merge in order unless marked parallel.