Increase kubeactions patch coverage#3100
Closed
frank-spano wants to merge 2 commits into
Closed
Conversation
|
Bits Code status: ✅ Done Comment @DataDog to request changes |
|
I can only run on private repositories. |
|
6eb9bac to
7ac41c5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## frank.spano-kube-actions #3100 +/- ##
============================================================
+ Coverage 43.62% 43.76% +0.13%
============================================================
Files 350 352 +2
Lines 30089 30138 +49
============================================================
+ Hits 13127 13190 +63
+ Misses 16090 16068 -22
- Partials 872 880 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds targeted unit tests to cover the recently changed kubeactions feature behavior and DatadogAgent test builder behavior so the PR patch is fully exercised.
Motivation
Patch coverage for PR #3099 showed uncovered lines in kubeactions feature no-op manager methods and the new KubeActions builder helpers. This change ensures those modified lines are executed and asserted by tests.
Additional Notes
Changes are intentionally limited to tests only.
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
go test ./internal/controller/datadogagent/feature/kubeactions ./pkg/testutilsinternal/controller/datadogagent/feature/kubeactions/feature.gono-op manager methods (ManageSingleContainerNodeAgent,ManageNodeAgent,ManageClusterChecksRunner,ManageOtelAgentGateway)pkg/testutils/builder.goKubeActions initialization and enabled flag mutation viaWithKubeActionsEnabledChecklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabelPR by Bits - View session in Datadog
Comment @DataDog to request changes