AIX: add live process monitoring#49162
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits intoApr 16, 2026
Merged
Conversation
Cherry-picked and adapted from #47041. Process collection logic previously in the DataDog/gopsutil fork has been vendored directly into pkg/process/procutil/process_aix.go, reading /proc/<pid>/psinfo without any dependency on DataDog/gopsutil.
pgimalac
added
changelog/no-changelog
github-actions
Bot
added
medium review
Contributor
Files inventory check summaryFile checks results against ancestor 7852cc86: Results for datadog-agent_7.79.0~devel.git.714.7b9bb45.pipeline.107754962-1_amd64.deb:No change detected |
Contributor
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
23 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 870ef14 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +1.62 | [-1.35, +4.59] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +1.62 | [-1.35, +4.59] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | +0.83 | [+0.59, +1.07] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_logs | % cpu utilization | +0.29 | [-1.28, +1.86] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_logs | memory utilization | +0.28 | [+0.22, +0.35] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.28 | [+0.05, +0.50] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.27 | [+0.10, +0.45] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.21 | [+0.10, +0.32] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.12 | [-0.41, +0.66] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.10 | [+0.07, +0.13] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.20, +0.22] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.01 | [-0.19, +0.21] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.01 | [-0.05, +0.07] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.11, +0.11] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.02 | [-0.43, +0.38] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.04 | [-0.17, +0.09] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.06 | [-0.11, -0.01] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.12 | [-0.55, +0.31] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.19 | [-0.34, -0.04] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | -0.33 | [-0.49, -0.18] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.38 | [-0.56, -0.19] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.39 | [-0.45, -0.33] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.82 | [-1.00, -0.64] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -0.84 | [-0.94, -0.74] | 1 | Logs |
Bounds Checks: ❌ Failed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 668 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 274.32MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 683 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.20GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.24GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.20GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.22GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ❌ | quality_gate_idle | intake_connections | 0/10 | 4 > 3 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 175.55MiB ≤ 181MiB | bounds checks dashboard |
| ❌ | quality_gate_idle_all_features | intake_connections | 5/10 | 4 > 3 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 495.09MiB ≤ 550MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 204.73MiB ≤ 220MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 364.07 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 412.38MiB ≤ 475MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
❌ Failed. Some Quality Gates were violated.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 0/10 replicas passed. Failed 10 which is > 0. Gate FAILED.
- quality_gate_idle_all_features, bounds check intake_connections: 5/10 replicas passed. Failed 5 which is > 0. Gate FAILED.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 67e474da68
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
pr_size and pr_rssize in AIX psinfo_t are in kilobytes, not pages. Using os.Getpagesize() (4096 on ppc64) inflated memory values by 4x.
wiyu
approved these changes
Apr 16, 2026
Member
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
pgimalac/aix-process-monitoring
branch
30 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add live process monitoring support for AIX:
pkg/process/procutil/process_aix.go: implements theProbeinterface by reading/proc/<pid>/psinfodirectly (world-readable 448-byte binary, no elevated privileges required). The psinfo struct layout is vendored from the DataDog/gopsutil fork — there is noDataDog/gopsutilimport.pkg/process/checks/system_info_aix.go:CollectSystemInfoimplementation for AIX via gopsutil v4.fp.Stats.CtxSwitchesandfp.CtxSwitchesnil dereferences inprocess.goandprocess_rt.go(AIX does not provide context switch data).process_fallback.goand the Linux-specificsystem_info.go.Motivation
Follow-up to #49052 and #49108. Cherry-picked and adapted from #47041.
Describe how you validated your changes
Cherry-picked from #47041, which has been tested manually on AIX.
Additional Notes
The process collection logic was originally added in the
DataDog/gopsutilfork. Since that fork is no longer used, the logic has been vendored directly into the agent.I'm working on upstreaming the logic to shirou/gopsutil but it's still WIP shirou/gopsutil#2028