✅ Create plugin navigation utils - #4485
Closed
BeltranBulbarellaDD wants to merge 6 commits into
Closed
Conversation
Bundles Sizes Evolution
🚀 CPU PerformancePending... 🧠 Memory PerformancePending... |
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: cfb899d | Docs | Datadog PR Page | Give us feedback! |
BeltranBulbarellaDD
changed the title
BeltranBulbarellaDD
marked this pull request as ready for review
April 21, 2026 08:29
| createTest('should not warn - edge case simulating NextJs with an extension that override `appendChild`') | ||
| .withExtension(createExtension(path.join(BASE_PATH, 'appendChild-extension'))) | ||
| .withRum() | ||
| .withRum({ sessionReplaySampleRate: 0 }) |
Collaborator
There was a problem hiding this comment.
❓ question: what is this for?
Contributor
Author
There was a problem hiding this comment.
Because at the end we assert withBrowserLogs((logs) => expect(logs.length).toBe(0)) I had a failed test because of a log of the recorder. Since we are not using sessionReplay in this test, I though of removing it by doing this.
Collaborator
There was a problem hiding this comment.
session replay should not log anything, what was the log?
Contributor
Author
|
Close until we find reason to believe we have serious flakyness in the CI for plugins |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some plugins tests are flaky the idea of this PR is to try and mitigate that.
Changes
Add
data-testidto plugin tests apps so we don't rely on hardcoded text.Create
navigationUtilsfor plugins with:Test instructions
Run the whole CI, specifically with
--repeat-eachoryarn playwright test --config test/e2e/playwright.local.config.ts -g "plugin"to run on all browsers.Checklist