Skip to content

refactor: Add Panel Component#844

Draft
lucaengelhard wants to merge 7 commits intoCyberTimon:mainfrom
lucaengelhard:refactor/panels
Draft

refactor: Add Panel Component#844
lucaengelhard wants to merge 7 commits intoCyberTimon:mainfrom
lucaengelhard:refactor/panels

Conversation

@lucaengelhard
Copy link
Copy Markdown

Description

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Performance improvement
  • Code refactoring
  • Documentation update
  • UI/UX improvement
  • Build/CI or Dependency update

Changes Made

  • Created a generic Panel Component system that removes the need for setting custom groups and handles the opening and closing a bit cleaner

Screenshots/Videos

Testing

  • I have tested these changes locally and confirmed that they work as expected without issues

Test Configuration:

  • OS: (e.g. Windows 11, macOS Sonoma, Ubuntu 24.04)
  • Hardware: (e.g. Intel i7, Apple M2, Nvidia RTX 3060)

Checklist

  • My code follows the project's code style
  • I haven't added unnecessary AI-generated code comments
  • My changes generate no new warnings or errors

Additional Notes

  • There still are some small animation issues that stem from me not really understanding the animation logic. Maybe this also can be fixed when the code gets cleaned up in general

AI Disclaimer:

Please state the involvement of AI in this PR:

  • This PR is entirely AI-generated
  • This PR is AI-generated but guided by a human
  • This PR was handwritten with AI assistance (spell check, logic suggestions, error resolving)
  • This PR contains only blood, sweat, and coffee (AI-free)

@CyberTimon
Copy link
Copy Markdown
Owner

Thanks for working on this. This is a great change :)

This hasn't updated yet, right?
image

@lucaengelhard
Copy link
Copy Markdown
Author

Thanks for working on this. This is a great change :)

This hasn't updated yet, right? image

Thanks! This currently still has some issues with animations and information flow. I need to work on it more. But it's also another point for a general refactor of the state management of the app, because its really hard to change anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants