Remove SvgJSON data type#1720
Conversation
Coverage Report for CI Build 0Coverage increased (+0.04%) to 58.298%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions13 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
| deleteWhere, entityKey, entityVal, insert, insert_, insertMany_, keyToValues, | ||
| selectFirst, selectList, (<-.), (==.)) | ||
| import Database.Tables hiding (paths, shapes, texts) | ||
| import Database.Tables |
There was a problem hiding this comment.
Please update the Database.Tables imports you changed so that they explicitly name what's being imported (this will help improve the code quality throughout)
| return (T.concat [firstName, ". ", lastName]) | ||
| parseInstr _ = return "" | ||
|
|
||
| -- | Parse the JSON representation of a graph into its texts, shapes, and paths components. |
There was a problem hiding this comment.
Rename to parseGraphComponentsJSON and move this into the graph model file
| let jsonObj = parseGraphJSON jsonStr | ||
| case jsonObj of | ||
| Nothing -> return $ toResponse ("Error" :: String) | ||
| Just svg -> do |
There was a problem hiding this comment.
rename svg into components
|
I have made the requested changes. I'm not sure if there are any rules for structuring imports (indenting, new lines) I should adhere to though. |
david-yz-liu
left a comment
There was a problem hiding this comment.
Nice work, @r-weng! The import style is good (and we can later apply a code formatter for the Haskell files to ensure consistent formatting).
Proposed Changes
This pull request removes the
SvgJSONdata type, previously defined inapp/Database/Tables.hs, and refactors any related code to use a tuple of texts, shapes, and paths instead ofSvgJSON. This pull request also createsparseGraphJSON, a helper function used insaveGraphJSONofapp/Controllers/Graph.hsandrunGetGraphJSONTestofbackend-test/Controllers/GraphControllerTests.hs.Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)