Skip to content

Fix: harden action and complete repo validation#274

Merged
0xLeif merged 5 commits into
mainfrom
0xleif/fix/harden-action-complete-validation
Jun 7, 2026
Merged

Fix: harden action and complete repo validation#274
0xLeif merged 5 commits into
mainfrom
0xleif/fix/harden-action-complete-validation

Conversation

@0xLeif
Copy link
Copy Markdown
Contributor

@0xLeif 0xLeif commented Jun 7, 2026

Summary

  • Harden the marketplace action by removing eval, requiring release checksums, validating coverage input, and documenting simple args parsing
  • Expand CI/fledge validation to cover Rust, specs, docs site, VS Code packaging, audit, and 100% spec coverage
  • Add the util spec, backfill missing spec companions, package the VS Code license, and bump the crate/changelog to 4.3.4

Test Plan

  • fledge run fmt
  • fledge run check-types
  • fledge run lint
  • fledge run test
  • fledge run build
  • fledge run audit
  • fledge spec check --strict
  • fledge run spec-check
  • ./target/release/specsync check --strict --require-coverage 100 --force
  • ./target/release/specsync score --all
  • fledge run docs-test
  • fledge run docs-lint
  • fledge run docs-build
  • fledge run vscode-compile
  • fledge run vscode-package
  • fledge plugins run gitleaks -- scan --no-git --redact
  • python3 -c "import yaml; yaml.safe_load(open('action.yml'))"

@0xLeif 0xLeif requested a review from a team as a code owner June 7, 2026 15:42
@0xLeif 0xLeif requested review from 0xGaspar, Kyntrin and tofu-ux June 7, 2026 15:42
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request hardens the GitHub Action command execution, input validation, and release checksum verification, while expanding CI validation and backfilling numerous specification companion files. It also replaces a tautological test assertion in the MCP module. The review feedback highlights two key issues: first, the bash argument parsing in action.yml will ignore subsequent lines of multi-line arguments, and second, the path assertion in src/mcp.rs is not cross-platform and will fail on Windows due to path separators.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread action.yml Outdated
Comment thread src/mcp.rs
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Corvin says...

      _
    <(;\  .oO(oh no...)
     |/(\
      \(\\
      " "\\

"I'm pecking through the errors..."

CI Summary

Check Status
Validate action.yml ✅ Passed
Dependency Audit ✅ Passed
Code Coverage ❌ failure
Format Check ✅ Passed
Docs Site ✅ Passed
Spec Validation ✅ Passed
Tests (build, test, clippy) ❌ failure
VS Code Extension ✅ Passed
📋 Spec Validation Details

✅ SpecSync: Passed

Metric Value
Specs checked 58
Passed 58
Errors 0
Warnings 0
File coverage 100% (74/74)
LOC coverage 100% (32661/32661)

Generated by specsync · Run specsync check --format github to reproduce


Powered by corvid-pet

@github-actions github-actions Bot dismissed their stale review June 7, 2026 15:56

Superseded by updated review.

github-actions[bot]
github-actions Bot previously approved these changes Jun 7, 2026
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Corvin says...

      _
    <(^\  .oO(Caw! ^v^)
     |/(\
      \(\\
      " "\\

"Caw! Found a shiny new spec!"

CI Summary

Check Status
Validate action.yml ✅ Passed
Dependency Audit ✅ Passed
Code Coverage ✅ Passed
Format Check ✅ Passed
Docs Site ✅ Passed
Spec Validation ✅ Passed
Tests (build, test, clippy) ✅ Passed
VS Code Extension ✅ Passed
📋 Spec Validation Details

✅ SpecSync: Passed

Metric Value
Specs checked 58
Passed 58
Errors 0
Warnings 0
File coverage 100% (74/74)
LOC coverage 100% (32663/32663)

Generated by specsync · Run specsync check --format github to reproduce


Powered by corvid-pet

github-actions[bot]
github-actions Bot previously approved these changes Jun 7, 2026
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Corvin says...

      _
    <(^\  .oO(Caw! ^v^)
     |/(\
      \(\\
      " "\\

"Caw! Your code sparkles like a dropped french fry."

CI Summary

Check Status
Validate action.yml ✅ Passed
Dependency Audit ✅ Passed
Code Coverage ✅ Passed
Format Check ✅ Passed
Docs Site ✅ Passed
Spec Validation ✅ Passed
Tests (build, test, clippy) ✅ Passed
VS Code Extension ✅ Passed
📋 Spec Validation Details

✅ SpecSync: Passed

Metric Value
Specs checked 58
Passed 58
Errors 0
Warnings 0
File coverage 100% (74/74)
LOC coverage 100% (32663/32663)

Generated by specsync · Run specsync check --format github to reproduce


Powered by corvid-pet

github-actions[bot]
github-actions Bot previously approved these changes Jun 7, 2026
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Corvin says...

      _
    <(^\  .oO(Caw! ^v^)
     |/(\
      \(\\
      " "\\

"That's a nice looking export you've got there."

CI Summary

Check Status
Validate action.yml ✅ Passed
Dependency Audit ✅ Passed
Code Coverage ✅ Passed
Format Check ✅ Passed
Docs Site ✅ Passed
Spec Validation ✅ Passed
Tests (build, test, clippy) ✅ Passed
VS Code Extension ✅ Passed
📋 Spec Validation Details

✅ SpecSync: Passed

Metric Value
Specs checked 58
Passed 58
Errors 0
Warnings 0
File coverage 100% (74/74)
LOC coverage 100% (32670/32670)

Generated by specsync · Run specsync check --format github to reproduce


Powered by corvid-pet

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Corvin says...

      _
    <(^\  .oO(Caw! ^v^)
     |/(\
      \(\\
      " "\\

"Caw! Your code sparkles like a dropped french fry."

CI Summary

Check Status
Validate action.yml ✅ Passed
Dependency Audit ✅ Passed
Code Coverage ✅ Passed
Format Check ✅ Passed
Docs Site ✅ Passed
Spec Validation ✅ Passed
Tests (build, test, clippy) ✅ Passed
VS Code Extension ✅ Passed
📋 Spec Validation Details

✅ SpecSync: Passed

Metric Value
Specs checked 58
Passed 58
Errors 0
Warnings 0
File coverage 100% (74/74)
LOC coverage 100% (32670/32670)

Generated by specsync · Run specsync check --format github to reproduce


Powered by corvid-pet

@0xLeif 0xLeif merged commit e1614db into main Jun 7, 2026
16 checks passed
@0xLeif 0xLeif deleted the 0xleif/fix/harden-action-complete-validation branch June 7, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant