Open
Conversation
Contributor
Ashod
commented
Apr 24, 2026
Ashod
commented
- wsd: convert Authorization::Type to STATE_ENUM
- browser: support non-wopi url and undefined accessTokenTtl
- wsd: better RequestDetails serialization
- browser: use legacy WS URL path for non-WOPI documents
- wsd: resetaccesstoken supports access_token_ttl
- wsd: Authorization supports refreshing tokens
- wsd: dump state for Authorization
- wsd: use Authorization::isValid() instead of isExpired()
- browser: reset token expiry timer on Reset_Access_Token
- browser: send App_TokenExpiring PostMessage to host
- wsd: retry save on uplaod failure after requesting token refresh
- wsd: add new configuration for access_token management
- wsd: test: access_token_ttl tests
Change-Id: I63a7cbca24222c3dcf4d034d387777a70bd826d3 Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Change-Id: Ieb4cc1a38a1e6322dd319c98df91c4d4a9fc93cf Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Change-Id: I3ffbeb3adbf25d80c8d47821aa1ccbdf4ee7b8e7 Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Change-Id: I49d08ef5ab4594132765b3ade2e9f1cf1e13fbf9 Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Adds an optional expiry time to the resetaccesstoken command. Authorization object also adds support to tracking this expiry time. Change-Id: I2c3b810bf73d6e03fc1ef22fd8fb6c08ee797efb Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
With tests. Change-Id: I37debc0123e46e582d6506c57326405cdb22d946 Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Change-Id: Ibedbf4126bdb45422a99c94b9bb52e557bd4b6ee Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
isValid covers the new Refresh-Token state. With tests. Change-Id: Ic9a8ebd1010195118fc143f74f9a598bd35a5092 Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Change-Id: Ie9b20763c9cfb1e115156b8c063f9d6e37fa73a3 Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
When the token expiry warning timer fires, send an App_TokenExpiring PostMessage to the integration. This prompts the integration to take action and keep the user's session valid. Change-Id: Iee7d838c173d40b33954807aa92ca6fc1e5ac7eb Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
When a PutFile gets an unauthorized respose, instead of immediately invalidating the token and going read-only, notify the client via a 'tokenexpired' message. The client sends App_TokenExpired PostMessage to the host, giving it a chance to send a fresh token via Reset_Access_Token. Change-Id: I183a442ddf7908065d89d2f334ea9647e34d683e Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This adds default lifetime (when access_token_ttl is missing), a timeout for refreshing tokens that are about to expire, and finally a time offset between the host and us. Change-Id: Id2f6601c19234b34de3c12cf7129b8098f6db439 Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Change-Id: I0b213c975fd5265b5ffe1fa12cb5759a9782ff1f Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
We give up warning of the access_token expiry roughly 5 minutes after it expires. Change-Id: I06c1b252f291985a4fa0d0090a55c00a415b53a6 Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
We retry resetaccesstoken up to 3 times before we give up and invalidate the access_token. Change-Id: I0a5fa9cad90bac9b3a397024b5a5e15f59f4a418 Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
caolanm
approved these changes
Apr 26, 2026
Contributor
caolanm
left a comment
caolanm
left a comment
There was a problem hiding this comment.
I think you might have to go via gerrit for new prs now (not sure of status of existing ones)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.