slideshow: improve slideshow sharpness#15646
Closed
lpranam wants to merge 1 commit intoCollaboraOnline:mainfrom
Closed
slideshow: improve slideshow sharpness#15646lpranam wants to merge 1 commit intoCollaboraOnline:mainfrom
lpranam wants to merge 1 commit intoCollaboraOnline:mainfrom
Conversation
lpranam
force-pushed
the
crisp_slideshow
branch
from
f553afe to
983db11
Compare
caolanm
reviewed
Apr 23, 2026
lpranam
force-pushed
the
crisp_slideshow
branch
from
983db11 to
6d6f722
Compare
lpranam
changed the title
lpranam
force-pushed
the
crisp_slideshow
branch
from
6d6f722 to
22c739e
Compare
lpranam
changed the title
caolanm
approved these changes
Apr 24, 2026
Contributor
|
Looks good in principle I think, but screenshots need to be updated I bet to get cypress tests to pass |
Use device pixel ratio when selecting the resolution tier so the offscreen canvas matches the display's physical pixels on HiDPI screens. Switch layer texture filtering to NEAREST to preserve pixel-exact rendering, and use Math.ceil for the width computation in computeLayerSize so the client-server dimensions agree and no row duplication artifact appears. For example, a standard 16:9 Impress page (25400x14288 twips) at the 3840x2160 tier: Math.trunc(2160 * 25400/14288) = 3839, which causes a 1-pixel height mismatch with the server (2159 vs 2160), producing a visible tear. Math.ceil gives 3840, so the server derives trunc(3840 * 14288/25400) = 2160 — an exact match. test screenshots updated to sharper shots Signed-off-by: Pranam Lashkari <lpranam@collabora.com> Change-Id: I6902f39677b626df8a7da2f54fefb30c1cc7faf0
lpranam
force-pushed
the
crisp_slideshow
branch
from
22c739e to
2f9a209
Compare
Member
Author
|
Moved to gerrit https://gerrit.collaboraoffice.com/c/online/+/1622 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use device pixel ratio when selecting the resolution tier so the
offscreen canvas matches the display's physical pixels on HiDPI
screens. Switch layer texture filtering to NEAREST to preserve
pixel-exact rendering, and use Math.ceil for the width computation
in computeLayerSize so the client-server dimensions agree and no
row duplication artifact appears.
For example, a standard 16:9 Impress page (25400x14288 twips) at
the 3840x2160 tier: Math.trunc(2160 * 25400/14288) = 3839, which
causes a 1-pixel height mismatch with the server (2159 vs 2160),
producing a visible tear. Math.ceil gives 3840, so the server
derives trunc(3840 * 14288/25400) = 2160 — an exact match.
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay