Fix the focus cell visibility issue with Freeze Rows And Columns#15638
Open
GulsahKose wants to merge 1 commit intoCollaboraOnline:mainfrom
Open
Fix the focus cell visibility issue with Freeze Rows And Columns#15638GulsahKose wants to merge 1 commit intoCollaboraOnline:mainfrom
GulsahKose wants to merge 1 commit intoCollaboraOnline:mainfrom
Conversation
FocusCellSection.onDraw drew the vertical column highlight and horizontal row highlight based on the raw cellCursorRectangle without accounting for split panes. When the cursor was scrolled "behind" the frozen area, the on-screen position computed by the documentObject translation landed inside the frozen pane region, so the highlight bars rendered over the frozen rows/columns. We run the cursor rectangle through CellCursorSection.adjustSizePos - the same helper CellCursorSection and OtherViewCellCursorSection already use to clip the cursor at split boundaries. Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com> Change-Id: I7fca5aba9293b7d7b1d4d6be91b06a0456bd68e5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FocusCellSection.onDraw drew the vertical column highlight and horizontal row highlight based on the raw cellCursorRectangle without accounting for split panes. When the cursor was scrolled "behind" the frozen area, the on-screen position computed by the documentObject translation landed inside the frozen pane region, so the highlight bars rendered over the frozen rows/columns.
We run the cursor rectangle through CellCursorSection.adjustSizePos - the same helper CellCursorSection and OtherViewCellCursorSection already use to clip the cursor at split boundaries.
Change-Id: I7fca5aba9293b7d7b1d4d6be91b06a0456bd68e5
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay