scroll: run panBy sync from drawSections#15636
Merged
Conversation
- reverted code from commit 623e2f5 "Scroll Section: Move move event into layouting tasks." It even mention: This will change in the future but for now, move event modifies map css prpoerty. - fixes regression after commit 5a672a7 "canvas: flush LayoutingService before canvas render" - makes order of processing again good for current frame: Original order (draw -> flush): 1. drawSections() - ScrollSection queues panBy 2. flushLayoutingTasks() - runs panBy synchronously Currently we flush tasks first, then will execute doMove() in ScrollSection which appends new task Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: I59937a918ef3a54c540a0c7a554720d9dea6c030
eszkadev
force-pushed
the
private/eszkadev/fix-scroll-scheduling
branch
from
a59f8f6 to
ee9aa2f
Compare
gokaysatir
approved these changes
Apr 23, 2026
Contributor
gokaysatir
left a comment
gokaysatir
left a comment
There was a problem hiding this comment.
Makes sense, thanks for the fix @eszkadev.
Member
|
pushed to cogerrit, too. |
Contributor
|
This issue is present in co-25.04 branch too I believe |
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reverted code from commit 623e2f5 "Scroll Section: Move move event into layouting tasks." It even mention: This will change in the future but for now, move event modifies map css prpoerty.
fixes regression after commit 5a672a7 "canvas: flush LayoutingService before canvas render"
makes order of processing again good for current frame: Original order (draw -> flush):
Currently we flush tasks first, then will execute doMove() in
ScrollSection which appends new task