jsdialog dropdown: Fix incorrect layout when no icon#15596
Merged
Conversation
Contributor
|
This fixes #15426 |
Issue: Open any calc document and right-click on a cell. Note that the entry `Paste Special` and `Sparkline` does not align with the rest of the items in the context menu which have icons. Solution: Add placeholder image for the entries without an icon. Signed-off-by: Dennis Francis <dennis.francis@collabora.com> Change-Id: I3aca2193e2e088426234e408ba74febcba4d5199
Signed-off-by: Dennis Francis <dennis.francis@collabora.com> Change-Id: I018eafda7aa335167ff5796d193f98211b3fa705
eszkadev
force-pushed
the
private/dennisf/jqcontext-layoutwithouticon
branch
from
a98d77a to
6ff7abe
Compare
eszkadev
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Also submenu entries need extra space for submenu-icon in grid.
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay