Open
Conversation
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: I6f7a5d5d0ffbda25a0275fbd73afa285e395258a
because <select> DOM elements have a .length property and so the focus is attempted on an inner option instead of the element itself. That wasn't the intent of the length check, just an unfortunate javascript collision Seen in the CSV Text Import Dialog. <select> DOM elements also have a .length property Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: I128c8b372d2ec837a2cd5b750614d41480c510f6
try the suggested focus candidate, if it can't take focus, try a child of that, then fallback to something from the list of candidates that can take focus, but with 'X' as lowest priority Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: I7923065cfdb99a69ebb8ca91e26225cf115b8b4b
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: Ia89aafd6fc2af1dc9567f4d7d945663384a8f232
caolanm
force-pushed
the
private/caolan/csv_import_dialog_focus
branch
from
902cf49 to
27a8d87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay