Dark mode icons are inverted in right click menu, but the correct ico…#15571
Open
Andreas-Kainz wants to merge 1 commit intomainfrom
Open
Dark mode icons are inverted in right click menu, but the correct ico…#15571Andreas-Kainz wants to merge 1 commit intomainfrom
Andreas-Kainz wants to merge 1 commit intomainfrom
Conversation
…ns are available Signed-off-by: Andreas-Kainz <kainz.a@gmail.com> Change-Id: I3f1486c0402b776c2d5ee9b2654404a007f3cefb
Contributor
|
It's not bout icons, it's about combobox entries which are "rendered" as images -> font list. |
eszkadev
reviewed
Apr 20, 2026
| border: 1px solid var(--color-primary); | ||
| } | ||
|
|
||
| [data-theme='dark'] .ui-combobox-entry img { |
Contributor
There was a problem hiding this comment.
we need that but for img:not( .... )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ns are available
Change-Id: I3f1486c0402b776c2d5ee9b2654404a007f3cefb
I'm not sure cause this css rule is in cool since 3 years and I'm a bit surprize that it's not correct.
However, ordinary ALL collibre icons should be also available as dark variant. So an css invert isn't needed I think.
But you know css rules can change at different places, so please I don't know why this rule exist.