Skip to content

Reuse shortcuts from core#15287

Closed
smehrbrodt wants to merge 3 commits intomainfrom
private/samuel/shortcutsfromcore
Closed

Reuse shortcuts from core#15287
smehrbrodt wants to merge 3 commits intomainfrom
private/samuel/shortcutsfromcore

Conversation

@smehrbrodt
Copy link
Copy Markdown
Contributor

@smehrbrodt smehrbrodt commented Mar 30, 2026

Reuse shortcuts from core instead of manually maintaining an incomplete list of shortcuts.
This is used for displaying shortcuts in tooltips, menus, etc.
Shortcuts from core used to work already, but they were not (always) displayed in the tooltip or menu.

  • Build shortcuts map from core shortcuts
  • Reuse key translations from core

@smehrbrodt smehrbrodt changed the title private/samuel/shortcutsfromcore Reuse shortcuts from core Mar 30, 2026
@smehrbrodt smehrbrodt requested a review from stbergmann March 30, 2026 12:11
@smehrbrodt smehrbrodt force-pushed the private/samuel/shortcutsfromcore branch 5 times, most recently from 0173790 to 08f21f0 Compare April 2, 2026 10:09
@smehrbrodt smehrbrodt force-pushed the private/samuel/shortcutsfromcore branch 3 times, most recently from 0b499ed to 34b9a81 Compare April 16, 2026 10:02
@smehrbrodt
Copy link
Copy Markdown
Contributor Author

@stbergmann CI is now green, can you please review?

@smehrbrodt smehrbrodt force-pushed the private/samuel/shortcutsfromcore branch from 34b9a81 to 743ac00 Compare April 16, 2026 12:48
@smehrbrodt
Copy link
Copy Markdown
Contributor Author

had to fix a minor issue...

Comment thread scripts/unoshortcuts.py
Comment thread browser/src/app/Util.ts
Comment thread browser/src/map/handler/Map.KeyboardShortcuts.ts
@smehrbrodt smehrbrodt force-pushed the private/samuel/shortcutsfromcore branch 2 times, most recently from a5f8642 to 9c9cb89 Compare April 20, 2026 08:45
@github-project-automation github-project-automation Bot moved this from To Review to To Test in Collabora Online Apr 20, 2026
Add script that fetches the shortcuts from core for all
uno commands used in online instead of manually maintaing a list
of such commands

Signed-off-by: Samuel Mehrbrodt <samuel.mehrbrodt@collabora.com>
Change-Id: I531e4fb89b3df04fea4121f6f101e0c812227b4d
Signed-off-by: Samuel Mehrbrodt <samuel.mehrbrodt@collabora.com>
Change-Id: I6664d93d89dc8219138ade7063bbc6c71f01c953
Signed-off-by: Samuel Mehrbrodt <samuel.mehrbrodt@collabora.com>
Change-Id: I3268ae0ace30d62878d29fafb3c401a8e5fbb0df
@smehrbrodt smehrbrodt force-pushed the private/samuel/shortcutsfromcore branch from 9c9cb89 to 2683578 Compare April 23, 2026 06:15
@smehrbrodt
Copy link
Copy Markdown
Contributor Author

@smehrbrodt smehrbrodt closed this Apr 23, 2026
@github-project-automation github-project-automation Bot moved this from To Test to Done in Collabora Online Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants