refactor(paintings): use inline artboard loading bar#16754
Merged
Conversation
Signed-off-by: gujiaming <52187003+AtomsH4@users.noreply.github.com>
Signed-off-by: gujiaming <52187003+AtomsH4@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the paintings Artboard loading UI from a centered spinner card to a compact inline status panel with an indeterminate progress bar, while keeping the cancel action available and updating the “generating” copy across locales.
Changes:
- Replace the motion-based spinner card with an inline status panel + progressbar in
Artboard. - Update the Artboard renderer test to cover the new loading UI.
- Update i18n copy for
paintings.generating(en-us, zh-cn, zh-tw).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/renderer/pages/paintings/components/Artboard.tsx | Replaces the centered spinner card with an inline status + progress bar and removes motion usage. |
| src/renderer/pages/paintings/components/tests/Artboard.test.tsx | Adds coverage for the new inline loading state + cancel action. |
| src/renderer/i18n/locales/zh-tw.json | Updates paintings.generating copy to the new guidance text. |
| src/renderer/i18n/locales/zh-cn.json | Updates paintings.generating copy to the new guidance text. |
| src/renderer/i18n/locales/en-us.json | Updates paintings.generating copy to the new guidance text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
eeee0717
approved these changes
Jul 6, 2026
kangfenmao
approved these changes
Jul 6, 2026
zhangjiadi225
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
The painting artboard showed a centered loading card with a spinning motion animation while image generation was running.
After this PR:
The painting artboard shows a compact inline status panel with an indeterminate progress bar, keeps the cancel action available, and updates the generation copy to tell users not to leave the page.
Fixes # N/A
Why we need it and why it was done in this way
The following tradeoffs were made:
Artboardbecause this is a single painting-specific UI state.motionusage from this component because the progress indicator no longer needs a JS-driven spinner.The following alternatives were considered:
Links to places where the discussion took place: N/A
Breaking changes
If this PR introduces breaking changes, please describe the changes and the impact on users.
N/A
Special notes for your reviewer
Validation:
pnpm lintpnpm docs:check-linkspnpm exec vitest run --silent --project renderer src/renderer/pages/paintings/components/__tests__/Artboard.test.tsxFull-suite note:
pnpm testwas run before the final rebase onto the latestorigin/main; it failed on the unrelated existingAgentComposer > opens the active session agent edit dialog from the toolbar trigger while keeping the model selector inlinetest. The targeted Artboard test was rerun and passes on the current branch.Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
mainfor active development,v1for v1 maintenance fixes/gh-pr-review,gh pr diff, or GitHub UI) before requesting review from othersRelease note