feat(composer): improve quick panel search aliases#16730
Open
ousugo wants to merge 2 commits into
Open
Conversation
6c16708 to
2c44b20
Compare
Signed-off-by: ousugo <dkzyxh@gmail.com>
2c44b20 to
0ca4fa4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
After this PR:
searchAliasesthat participate in filtering without changing rendered labels.filterTextbehavior for items such as agent skills.PixPin_2026-07-04_06-10-11.mp4
Fixes # N/A
Why we need it and why it was done in this way
The following tradeoffs were made:
searchAliasesare hidden metadata instead of rendered text, so the UI remains localized while search accepts English names across locales.filterTextauthoritative and only expands it with hidden aliases, avoiding accidental broadening of agent skill searches.The following alternatives were considered:
Links to places where the discussion took place: N/A
Breaking changes
None.
If this PR introduces breaking changes, please describe the changes and the impact on users.
N/A
Special notes for your reviewer
Validation run locally:
vitest run --project renderer src/renderer/components/composer/variants/__tests__/ChatComposer.test.tsx src/renderer/components/composer/variants/__tests__/AgentComposer.test.tsx— 125 tests passed.vitest run --project rendereron focused QuickPanel and Composer tool test files — 39 tests passed.pnpm typecheck:webpassed.biome checkon touched files passed.git diff --checkpassed./gh-pr-reviewwas run in report-only mode; follow-up findings were addressed.Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
mainfor active development,v1for v1 maintenance fixes/gh-pr-review,gh pr diff, or GitHub UI) before requesting review from othersRelease note