Move to dependency groups approach for pip installs#570
Move to dependency groups approach for pip installs#570joewallwork merged 6 commits into368_rework-pt2tsfrom
pip installs#570Conversation
joewallwork
added
testing
jatkinson1000
left a comment
jatkinson1000
left a comment
There was a problem hiding this comment.
Hi @joewallwork generally happy with the premise here
I wonder whether we want dependency-groups over optional-dependencies though?
Also, simple users may not be so familiar with the developer Python features, so I'd either explicitly link to the installation instructions from the README examples or provide specific installation commands as part of the tutorial.
|
Sorry to be pedantic over 3bd91d2, but I don't think NumPy is a core dependency of FTorch itself, only of pt2ts/ftorch-utils or the examples? And if installing ftorch-utils it will be pulled as a dependency of that automatically. |
Whilst not a core dependency of FTorch, I think I'd keep it as a main dependency in the pyproject.toml file to prevent warnings when using pt2ts? |
Done in 9608aa2. |
jatkinson1000
left a comment
jatkinson1000
left a comment
There was a problem hiding this comment.
@joewallwork Go Go Goooooo (once tests pass)
* Make pt2ts runnable * Rename utils as ftorch_utils and update README * Separate TorchScript utils into a module * Implement load_pytorch_model * Move to pyproject.toml * Install pt2ts into the Python environment * Install ftorch_utils in CI workflows * Enable testing in pt2ts * Use pt2ts script in examples * Changelog * Update example READMEs * Update mention of pt2ts script in the docs * Improve clarity of GPU device docs * Add note on ResNet example * Rename ResNet old-style pt2ts to write_torchscript * Use better naming scheme for PyTorch and TorchScript model files * Save example models in binary dirs * Use --extra-index-url and mention in docs * Add release checklist step for updating ftorch_utils version * Move to dependency groups approach for `pip install`s (#570) --------- Co-authored-by: Jack Atkinson <109271713+jatkinson1000@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
2 participants
Merges into #555
This PR moves the
pip installapproach to make use of dependency groups, which will soon be the recommended approach. They will replace the use ofrequirements.txt(andrequirements-dev.txt, etc) and also extras like[dev].