migrated from lineTo() -> addPolygon()#19
Open
TamilKannanCV wants to merge 1 commit intoCRED-CLUB:mainfrom
Open
migrated from lineTo() -> addPolygon()#19TamilKannanCV wants to merge 1 commit intoCRED-CLUB:mainfrom
TamilKannanCV wants to merge 1 commit intoCRED-CLUB:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
We have used
lineTo(x, y)to draw the Polygon for our Button (Tile Button, Card). The problem here is thelineTo(x, y)is called multiple times which is not a good approach for drawing a polygon. This leads to a slight drop in performance.Type of change
✅ Enhancement
Solution Approach
To solve this issue, I've used
addPolygon([], true)instead oflineTo(x, y)functions. This is the most efficient approach to solve the problem.Reference
About Me
I'm Tamil Kannan, an experienced Flutter developer, open to work at CRED.