CMake: auto-enable CGAL_DEV_MODE when building from CGAL source tree#9472
Open
shresthbhargava wants to merge 1 commit into
Open
CMake: auto-enable CGAL_DEV_MODE when building from CGAL source tree#9472shresthbhargava wants to merge 1 commit into
shresthbhargava wants to merge 1 commit into
Conversation
Fixes CGAL#9441. When cgal_detect_branch_build() returns TRUE, CGAL_DEV_MODE now defaults to ON instead of requiring developers to set the environment variable manually. Falls back to $ENV{CGAL_DEV_MODE} if set, otherwise OFF for external users. A CMake WARNING is printed when auto-enabled so users know the setting is active and how to disable it with -DCGAL_DEV_MODE=OFF.
Member
|
The message should mention |
Author
|
Updated the warning message to include the wiki link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9441.
Problem
CGAL_DEV_MODEhad nooption()declaration inCGALConfig.cmake.Developers building from the CGAL source tree had to manually set
CGAL_DEV_MODE=ONin their shell profile — easy to miss for new contributors.Fix
cgal_detect_branch_build(), compute_cgal_dev_mode_default:ONifBRANCH_BUILDis true$ENV{CGAL_DEV_MODE}if the env var is setOFFotherwise (external/installed CGAL users unaffected)option(CGAL_DEV_MODE ...)with that defaultmessage(WARNING)when auto-enabled so developers knowit's active and can disable it with
-DCGAL_DEV_MODE=OFFTesting
CGAL_DEV_MODE=ON✓-DCGAL_DEV_MODE=OFF→ no warning, flag OFF ✓