New package: Feature graph by ange-clement · Pull Request #9465 · CGAL/cgal

ange-clement · 2026-05-06T15:38:15Z

Summary of Changes

New package "Feature graph" that contains methods to extract sharp features from 3D images.

Tasks

Validate API
Integrate code
Test
Manual and examples

Release Management

Affected package(s):
Issue(s) solved (if any):
Feature/Small Feature (if any):
Link to compiled documentation (obligatory for small feature)
License and copyright ownership:

Feature graph is now an VertexAndEdgeListGraph Lowercase in passive form in --> on regularization isthmus distance parameter Element type is now CGAL::Dimension_tag

albert-github

should be /// @{ instead of // @{

occurs in multiple files.

(I didn't really review it but this caught my eye)

ange-clement · 2026-05-06T16:20:58Z

lrineau · 2026-05-07T08:01:15Z

/build:doc-wip

It will be placed back once the API is validated

github-actions · 2026-05-07T08:15:24Z

There was an error while building the doc:

/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/PackageDescription.txt:42: warning: unable to resolve reference to 'PkgDEPENDENCY' for \ref command
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/detect_sharp_features.h:26: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/detect_sharp_features.h:30: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/detect_sharp_features.h:91: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/optimization_parameters.h:171: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/optimization_parameters.h:173: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/optimization_parameters.h:171: warning: argument 'plane_detection_distance' of command @param is not found in the argument list of CGAL::Optimization_parameters_on_image< NormalEstimator >::Optimization_parameters_on_image(const NamedParameters &np=parameters::default_values())
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/optimization_parameters.h:171: warning: argument 'normal_estimator' of command @param is not found in the argument list of CGAL::Optimization_parameters_on_image< NormalEstimator >::Optimization_parameters_on_image(const NamedParameters &np=parameters::default_values())
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/optimization_parameters.h:274: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/optimization_parameters.h:276: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/optimization_parameters.h:274: warning: argument 'plane_detection_distance' of command @param is not found in the argument list of CGAL::Optimization_parameters_on_surface< NormalEstimator >::Optimization_parameters_on_surface(const NamedParameters &np=parameters::default_values())
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/optimization_parameters.h:274: warning: argument 'normal_estimator' of command @param is not found in the argument list of CGAL::Optimization_parameters_on_surface< NormalEstimator >::Optimization_parameters_on_surface(const NamedParameters &np=parameters::default_values())
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/regularization_parameters.h:102: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/regularization_parameters.h:104: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/regularization_parameters.h:212: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/CGAL/regularization_parameters.h:214: warning: unable to resolve reference to 'bgl_namedparameters' for \ref command
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/Feature_graph.txt:22: warning: unable to resolve reference to '\n' for \ref command
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/Feature_graph.txt:22: warning: unexpected token TK_COMMAND_BS as the argument of include
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/Feature_graph.txt:24: warning: image file bench.png is not found in IMAGE_PATH: assuming external image.
/home/runner/work/cgal/cgal/Feature_graph/doc/Feature_graph/Feature_graph.txt:24: warning: image file bench.png is not found in IMAGE_PATH: assuming external image.
Error: Figure numbering; fig__figPck has not been collected

https://github.com/CGAL/cgal/actions/runs/25483628171

ange-clement · 2026-05-07T09:22:40Z

/build:doc-wip

github-actions · 2026-05-07T09:27:05Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9465/doc/Manual/index.html

ange-clement · 2026-05-07T12:55:53Z

/build:doc-wip

github-actions · 2026-05-07T12:59:43Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9465/doc/Manual/index.html

lrineau · 2026-05-19T08:43:05Z

The CI says that the file Feature_graph/package_info/Feature_graph/dependencies is missing and should contain

Installation
STL_Extension

ange-clement · 2026-05-19T08:57:09Z

The CI says that the file Feature_graph/package_info/Feature_graph/dependencies is missing and should contain
Installation
STL_Extension

Ok, I didn't understand because the package creation script only generate the file Feature_graph/doc/Feature_graph/dependencies which did contain STL_Extension...

The API will be templeted internally for the images, but this will stay undocumented until a more suitable location for this concept is created.

ange-clement · 2026-06-19T15:34:59Z

/build:doc-wip

github-actions · 2026-06-19T15:37:24Z

There was an error while building the doc:

https://github.com/CGAL/cgal/actions/runs/27834859744

albert-github · 2026-06-19T15:46:29Z

I saw this problem regarding the PR's documentation now a couple of times and I have the suspicion that this might have to do with the recent change to a newer version of doxygen 1.9.6 to 1.17.0) probably somewhere some logic is not working as expected.
(@sloriot )

ange-clement · 2026-06-24T07:48:56Z

/build:doc-wip

github-actions · 2026-06-24T07:51:23Z

There was an error while building the doc:

https://github.com/CGAL/cgal/actions/runs/28083547975

…h-aclement

ange-clement · 2026-06-29T09:17:56Z

/build:doc-wip

github-actions · 2026-06-29T09:19:32Z

There was an error while building the doc:

This round already exists. Overwrite it with /force-build.

https://github.com/CGAL/cgal/actions/runs/28361631146

ange-clement · 2026-06-29T09:33:20Z

/force-build:doc-wip

github-actions · 2026-06-29T09:37:03Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9465/doc/Manual/index.html

afabri · 2026-06-29T16:03:45Z

@ange-clement est-ce que tu peux repondre aux remarques que j'ai fait.

afabri · 2026-06-29T16:09:07Z

afabri · 2026-06-29T16:09:39Z

There is Reference Manual inside Reference Manual

Renamed ..._on_X to X_..._estimator Changed Sharpness_value_type to Sharpness_number_type

Add example CMakeLists + added typename

ange-clement · 2026-07-03T13:35:23Z

/force-build:doc-wip

github-actions · 2026-07-03T13:39:00Z

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9465/doc-wip/Manual/index.html

afabri · 2026-07-06T06:35:14Z

+  *
+  *   \cgalParamSectionBegin{point_to_element_output_map}
+  *     \cgalParamDescription{an output property map that will be filled if supplied.
+  *     It allow retrieving of the surface element where a feature graph point is embedded.


Suggested change

* It allow retrieving of the surface element where a feature graph point is embedded.

* It enables retrieving of the surface element where a feature graph point is embedded.

@efifogel once pointed out to me that we use the word "allow" often in a wrong way. It should be "enable" most of the time. See here for a discussion.

afabri · 2026-07-06T06:40:05Z

+  *     and must implement `put(output_pmap, feature_vertex_descriptor, facet_descriptor)`
+  *     where the key type is the `vertex_descriptor` of the feature graph, and the value type is
+  *     a descriptor of an element of the surface, with type `std::size_t`.
+  *     The facet descriptor correspond to a facet element with the tag `CGAL::DimensionTag<2>`}


Is that on purpose "facet" instead of "face"?

afabri · 2026-07-06T06:42:26Z

+  *         </UL>
+  *         <LI> The type `DimensionTag` represents the element type, it can either be `CGAL::Dimension_tag<0>`, `CGAL::Dimension_tag<1>` or `CGAL::Dimension_tag<2>`,
+  *         which represent either a vertex element, an edge element, or a facet element respectively.
+  *         <LI> The type `Descriptor` is either a `vertex_descriptor`, `halfedge_descriptor` or `face_descriptor` and


Coming back to "facet", even if was the correct mathematical term, I suggest to call it face, as we use a face_descriptor for it.

afabri · 2026-07-06T06:43:09Z

+  *         If it is a scalar field, it must implement
+  *         <UL>
+  *           <LI> `template <typename DimensionTag, typename Descriptor>`
+  *           <BR> `FT operator()(const Point_3& point_in_space, const Descriptor& element_descriptor, const PolygonMesh& pmesh) const`


Why the suffix _in_space?

afabri · 2026-07-08T05:21:13Z

+if (MSVC)
+  add_compile_options(/bigobj)
+else ()
+  add_compile_options(-Wa,-mbig-obj)


Is this really needed ? It gives error messages in the testsuite

afabri · 2026-07-08T05:29:39Z

@@ -0,0 +1,127 @@
+// WARNING : non-functioning example. This exmaple is to understand how to create and use the feature graph for tetrahedral mesh creation.


What do you mean with "non-functionning"??

ange-clement added 6 commits April 10, 2026 11:11

Feature graph initial commit

c7fe36a

Initial API for Feature graph

f3c299e

Updated API for Feature graph

dee6f63

API Changes

6953ea2

Feature graph is now an VertexAndEdgeListGraph Lowercase in passive form in --> on regularization isthmus distance parameter Element type is now CGAL::Dimension_tag

Regularization parameters

b85a0b7

Fix missing quote + Use stars for doc

bf7c751

albert-github reviewed May 6, 2026

View reviewed changes

Changed "// @" to "/// @"

43701aa

lrineau added Not yet approved The feature or pull-request has not yet been approved. Work in progress labels May 7, 2026

lrineau changed the title ~~Feature graph: Package creation~~ New package: Feature graph May 7, 2026

Temporarily moved doc folder

106d1bb

It will be placed back once the API is validated

Moved measures to namespace Feature_graph

b175e0a

ange-clement added 3 commits May 7, 2026 12:01

Fixed missing link

a5a7b7a

Add GPL License

c0d790f

Moved the documentation and created minimum files

cc3669a

MaelRL added the Feature label May 18, 2026

MaelRL modified the milestones: 6.2-beta, 6.3-beta May 18, 2026

Added package dependencies

a104997

Removed concept FeatureImage_3

2da740b

The API will be templeted internally for the images, but this will stay undocumented until a more suitable location for this concept is created.

ange-clement added 2 commits June 25, 2026 16:24

Merge branch 'main' of https://github.com/CGAL/cgal into Feature_grap…

49a34d3

…h-aclement

Merge branch 'main' of https://github.com/CGAL/cgal into Feature_grap…

d58ce24

…h-aclement

afabri requested changes Jun 30, 2026

View reviewed changes

afabri reviewed Jun 30, 2026

View reviewed changes

Comment thread Feature_graph/doc/Feature_graph/PackageDescription.txt Outdated

afabri requested changes Jun 30, 2026

View reviewed changes

Comment thread Feature_graph/doc/Feature_graph/PackageDescription.txt Outdated

Comment thread Feature_graph/doc/Feature_graph/PackageDescription.txt Outdated

Comment thread Feature_graph/doc/Feature_graph/PackageDescription.txt Outdated

ange-clement added 4 commits July 3, 2026 11:26

Added an example

f2d550f

Renamed ..._on_X to X_..._estimator Changed Sharpness_value_type to Sharpness_number_type

Made the example compiles

7c64c5e

Add example CMakeLists + added typename

Removed whitespace

2de78f0

Removed whitespace 2 : electric boogaloo

140b954

Feature_graph : Include Named_function_parameters for example

0526708

afabri requested changes Jul 6, 2026

View reviewed changes

sloriot added the Under Testing label Jul 7, 2026

afabri reviewed Jul 8, 2026

View reviewed changes

sloriot removed the Under Testing label Jul 8, 2026

	* It allow retrieving of the surface element where a feature graph point is embedded.
	* It enables retrieving of the surface element where a feature graph point is embedded.

		@@ -0,0 +1,127 @@
		// WARNING : non-functioning example. This exmaple is to understand how to create and use the feature graph for tetrahedral mesh creation.

Uh oh!

Conversation

ange-clement commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Tasks

Release Management

Uh oh!

albert-github left a comment

Choose a reason for hiding this comment

Uh oh!

ange-clement commented May 6, 2026

Uh oh!

lrineau commented May 7, 2026

Uh oh!

github-actions Bot commented May 7, 2026

Uh oh!

ange-clement commented May 7, 2026

Uh oh!

github-actions Bot commented May 7, 2026

Uh oh!

ange-clement commented May 7, 2026

Uh oh!

github-actions Bot commented May 7, 2026

Uh oh!

lrineau commented May 19, 2026

Uh oh!

ange-clement commented May 19, 2026

Uh oh!

ange-clement commented Jun 19, 2026

Uh oh!

github-actions Bot commented Jun 19, 2026

Uh oh!

albert-github commented Jun 19, 2026

Uh oh!

ange-clement commented Jun 24, 2026

Uh oh!

github-actions Bot commented Jun 24, 2026

Uh oh!

ange-clement commented Jun 29, 2026

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

ange-clement commented Jun 29, 2026

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

afabri commented Jun 29, 2026

Uh oh!

afabri commented Jun 29, 2026

Uh oh!

afabri commented Jun 29, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ange-clement commented Jul 3, 2026

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

afabri Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

afabri Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

afabri Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

afabri Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

afabri Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

ange-clement commented May 6, 2026 •

edited

Loading