InventorySlot fixes, Workbench Dupe fix#6392
Open
MalkContent wants to merge 3 commits into
Open
Conversation
…ift-click-insert fixes related issue with UpgradeableTools voiding items (only affected Additional Augers, as currently sole stackable item in UpgradeableTool item inventories) fixes item dupe bug with workbench where excess items would be spawned/dropped into the world, but also remain in Player inventory IEContainerMenu.moveItemStackToWithMayPlace: added much needed description added reverseDirection sensitivity fixed premature return
… for reverseDirection, fixed premature return removed obsolete commented out line in ModWorkbenchContainer
Contributor
Author
|
This PR has a workaround that should get removed if |
Contributor
Author
|
ah fuck. This has issues with the buzzsaw quiver not updating correctly. Glad I checked, but give me a moment |
back to how it used to work, kinda dropped IESlot.Upgrades' old "getItem" override, though. Tried to replace it with a getStackCopy override, but it works without it and with it, I got stack overflows which I did not understand. .. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6177
fixes related issue with UpgradeableTools voiding items (only affected Additional Augers, as currently sole stackable item in UpgradeableTool item inventories)
fixes #6393
IEContainerMenu.moveItemStackToWithMayPlace:
added much needed description (sorry for not adding that 5 years ago)
added reverseDirection sensitivity
fixed premature return