Skip to content

Fix bug in 'scoped' polyfill (BL-16510) #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrew-polk merged 4 commits into from
Jul 8, 2026
Merged

Fix bug in 'scoped' polyfill (BL-16510) #431

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8ec888d
chore: add unmodified scoped styles polyfill from style-scoped package
JohnThomson Jul 7, 2026
7fd10cb
fix: correct attribute selector regex in CSS scoped styles polyfill
JohnThomson Jul 7, 2026
daeea22
chore: remove style-scoped dependency
JohnThomson Jul 7, 2026
37a6045
chore: extract selector logic so tests exercise production code
JohnThomson Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
"react": "17.0.2",
"react-dom": "17.0.2",
"react-id-swiper": "2.3.2",
"style-scoped": "0.2.2",
"swiper": "4.5.1"
},
"devDependencies": {
Expand Down
8 changes: 0 additions & 8 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions src/bloom-player-core.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@ bloom-player-core is responsible for all the behavior of working through a book,
import * as React from "react";
import axios from "axios";
import Swiper, { SwiperInstance } from "react-id-swiper";
// This loads some JS right here that is a polyfill for the (otherwise discontinued) scoped-styles html feature
import "style-scoped/scoped.min.js";
// This loads some JS right here that is a polyfill for the (otherwise discontinued) scoped-styles html feature.
// We use a patched version that fixes a bug with comma-separated selectors containing attribute selectors.
import "./scoped-styles-polyfill.js";
import "swiper/dist/css/swiper.min.css";
import "./bloom-player-ui.less";
import "./bloom-player-content.less";
Expand Down
Loading