Skip to content

Prevent infinite recursion reporting a problem #8031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StephenMcConnel wants to merge 1 commit into
base: master
Choose a base branch
from
+21 −7
Open

Prevent infinite recursion reporting a problem #8031

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions src/BloomExe/NonFatalProblem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ public enum PassiveIf
/// </summary>
public class NonFatalProblem
{
// Guard against reentrant calls (e.g. ShowToast → SendBundle → ReportConnectionError → Report)
// which cause infinite mutual recursion leading to a StackOverflowException.
[ThreadStatic]
private static bool s_isReporting;

/// <summary>
/// Always log, possibly inform the user, possibly throw the exception
/// </summary>
Expand Down Expand Up @@ -164,15 +169,24 @@ public static void Report(
if (
!string.IsNullOrEmpty(shortUserLevelMessage)
&& Matches(passive).Any(s => channel.Contains(s))
&& !s_isReporting
)
{
ShowToast(
shortUserLevelMessage,
exception,
fullDetailedMessage,
showSendReport,
showRequestDetails
);
s_isReporting = true;
try
{
ShowToast(
shortUserLevelMessage,
exception,
fullDetailedMessage,
showSendReport,
showRequestDetails
);
}
finally
{
s_isReporting = false;
}
}
}
catch (Exception errorWhileReporting)
Expand Down