-
Notifications
You must be signed in to change notification settings - Fork 2
Next Release #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Next Release #18
Changes from 4 commits
Commits
Show all changes
121 commits
Select commit
Hold shift + click to select a range
352b6f6
Allow column preselection for filter inclusion
Jeff-Thompson12 665a25f
Update shiny_data_filter.R
jhk0530 c4456d7
Add basic framework
Jeff-Thompson12 cbffcd5
Implement using an expression in numeric many
Jeff-Thompson12 9ab2e48
Set `dev` version
Jeff-Thompson12 f37bb03
Merge pull request #16 from jhk0530/master
Jeff-Thompson12 0ea052c
Utilize `%||%()` and set appropriate empty data structure
Jeff-Thompson12 dbd733b
Update NEWS
Jeff-Thompson12 199eccb
Merge pull request #19 from Biogen-Inc/jt-15-NULL_cannot_have_attributes
Jeff-Thompson12 f325ba5
Merge branch 'devel' into jt-13-preselection
Jeff-Thompson12 1e7672a
Update documentation
Jeff-Thompson12 8e0b38d
Use timezone of vector instead of trying to specify
Jeff-Thompson12 0531c0a
Change `filter_expr` to `filter_fn`
Jeff-Thompson12 349a67f
Turn back to silently failing for now
Jeff-Thompson12 1615f92
Implement preselection for datetime types
Jeff-Thompson12 aa5bfa5
Update other methods with preselection
Jeff-Thompson12 708f9c6
Update NEWS
Jeff-Thompson12 2b32f77
Move preselection argument to end
Jeff-Thompson12 b19b56f
Make preselection reactive
Jeff-Thompson12 ac7aeb3
Make application of filter pre-selection a function
Jeff-Thompson12 8afdbd9
Allow chaning/updating filter pre-selection
Jeff-Thompson12 9d8ab8e
Merge pull request #21 from Biogen-Inc/jt-17-fix_shiny_vector_datetime
AARON-CLARK 2a2da74
Resolve merge conflicts with `devel`
Jeff-Thompson12 aedd0ff
Update documentation
Jeff-Thompson12 7cfaf06
Add wrappers for data filter item
Jeff-Thompson12 93a5e81
Add wrappers for shiny data filter
Jeff-Thompson12 262e616
Update NEWS
Jeff-Thompson12 9b00b3d
Add reader readme action
Jeff-Thompson12 e8a5d43
Update README to use wrappers
Jeff-Thompson12 4ebe124
Re-build Rmarkdown files
Jeff-Thompson12 88b9a29
Clean up comments and examples a little
Jeff-Thompson12 5cfa425
Merge branch 'jt-22-utilize_moduleServer' of https://github.com/Bioge…
Jeff-Thompson12 f7711b4
Re-build Rmarkdown files
Jeff-Thompson12 52205e1
Separate out IDEAFilter modules
Jeff-Thompson12 827917d
Add new filters using modern module implementation
Jeff-Thompson12 144ddbb
Add tests for new implementation
Jeff-Thompson12 0574fbc
Update example apps
Jeff-Thompson12 7b5f4ab
Fix bug when changing dataset
Jeff-Thompson12 a1c3b77
Repair `data_call`
Jeff-Thompson12 b1caa5b
Repair bug when switching datasets with added filters
Jeff-Thompson12 7e76a4e
Update documentation
Jeff-Thompson12 4faa89d
Add tests for reactive data
Jeff-Thompson12 8e65c5c
Add waiter
Jeff-Thompson12 bf403ff
Update NEWS
Jeff-Thompson12 bdacdbd
Merge pull request #23 from Biogen-Inc/jt-22-utilize_moduleServer
Jeff-Thompson12 45c7993
Merge branch 'devel' into jt-13-preselection
Jeff-Thompson12 938236e
Implement pre-selection using `IDEAFilter()`
Jeff-Thompson12 1c5b475
Increment version number
Jeff-Thompson12 5d07343
Implement column subsetting
Jeff-Thompson12 ff438ab
Update NEWS
Jeff-Thompson12 c59d597
Update documentation
Jeff-Thompson12 7786326
Merge pull request #24 from Biogen-Inc/jt-14-column_subsetting
Jeff-Thompson12 4cafa9e
Use `pillar::type_sum()` instead of `pillar::new_pillar_type()`
Jeff-Thompson12 e542fae
Update NEWS
Jeff-Thompson12 b739a0f
Merge pull request #25 from Biogen-Inc/jt-9-use_type_sum
Jeff-Thompson12 27ec963
Merge branch 'devel' into jt-13-preselection
Jeff-Thompson12 3431cd6
Fix merge conflicts with `dev`
Jeff-Thompson12 a25f48c
Fix bug with NAs imcorrectly displaying
Jeff-Thompson12 fafe952
Fix issue where `IDEAFilter()` was pointing to `shiny_data_filter_ite…
Jeff-Thompson12 0a959d6
Simplify `code()` reactive in `IDEAFilter()`
Jeff-Thompson12 3de74d3
Add test for pre-selection
Jeff-Thompson12 770555b
Increment version number
Jeff-Thompson12 5c2bb92
Merge pull request #20 from Biogen-Inc/jt-13-preselection
Jeff-Thompson12 8231cc8
Initialize vignettes
Jeff-Thompson12 3c5b24d
Don't reinitialize modules on resort
Jeff-Thompson12 7854af2
Repair test for IDEAFilter_item
Jeff-Thompson12 59b70b0
Add erase filter selection feature
Jeff-Thompson12 2c6e9bd
Remove inputs when exiting module
Jeff-Thompson12 de0cc04
Remove observers when exiting vector module
Jeff-Thompson12 34ea8c1
Increment version number
Jeff-Thompson12 b9e1bec
Add data to test data types
Jeff-Thompson12 fc1301d
Fix bug causing the erase filters event to trigger
Jeff-Thompson12 b0f97db
Update NEWS
Jeff-Thompson12 ef20ba4
Update NEWS again
Jeff-Thompson12 b42d5b5
Merge pull request #26 from Biogen-Inc/jt-vector_filter
Jeff-Thompson12 846749d
Require data
Jeff-Thompson12 0dd4bb1
Add checks for data being present
Jeff-Thompson12 41bc20c
Increment version number
Jeff-Thompson12 a917cd3
Merge pull request #27 from Biogen-Inc/jt-test_tidyCDISC
Jeff-Thompson12 2c4cc7c
Fix bug when switching between numeric few and many
Jeff-Thompson12 a0092bb
Add `try()` when destroying observer
Jeff-Thompson12 8c6d78e
Fix merge conflicts with `devel`
Jeff-Thompson12 d702a75
Update version number
Jeff-Thompson12 4aa8583
Resolve minor bug when switching from character vector
Jeff-Thompson12 0071ceb
Update authorship
Jeff-Thompson12 63295ab
Separate inputs in numeric few and many
Jeff-Thompson12 cdf4e1e
Update example apps
Jeff-Thompson12 a86572e
Flesh out vignette a little more
Jeff-Thompson12 736d49f
Change implementation of column subsetting
Jeff-Thompson12 2377a0c
Increment version number
Jeff-Thompson12 b343dbf
Update `columnSelectInput()`
Jeff-Thompson12 879cfbd
Merge pull request #28 from Biogen-Inc/jt-extend_col_subset
Jeff-Thompson12 162a16c
Merge branch 'devel' into jt-6-add_vignettes
Jeff-Thompson12 a011445
Increment version number
Jeff-Thompson12 dcc21a5
Re-build Rmarkdown files
Jeff-Thompson12 b46555f
Repair tests
Jeff-Thompson12 73cee62
Resolve some warnings
Jeff-Thompson12 e63c145
Resolve issue where column subsets were not getting updated
Jeff-Thompson12 53a4709
Flesh out vignette a little more
Jeff-Thompson12 d9d2f12
Update some language in vignette
Jeff-Thompson12 8cd8318
Merge pull request #29 from Biogen-Inc/jt-6-add_vignettes
Jeff-Thompson12 33e18ee
Fix some issues introduced by changes in selectize.js
jthompson-arcus 3829ec3
Fix minor bug applying NA filter to logical vector
jthompson-arcus c07de5a
Don't show deprecated message for `shiny_data_filter_item` when calle…
jthompson-arcus 27de7cf
Polish NEWS
jthompson-arcus d97d981
Fix URL redirect
jthompson-arcus c512f02
Update CRAN comments
jthompson-arcus 747a746
Increment for minor release
jthompson-arcus 69ddbcd
Update cran-comments.md
jthompson-arcus 796bb24
.Rbuildignore, description, CRAN-SUB file changed
aclark02-arcus 3b7224f
Update LICENSE.md
tidyCDISC e4c9a4a
Update LICENSE
tidyCDISC 77a5263
Update README.Rmd
tidyCDISC 41beb93
re-compile readme.md
aclark02-arcus 6a3f369
push updated cran-comments
aclark02-arcus 3f225ee
Add cran submission file
aclark02-arcus 622758d
Update DESCRIPTION's reference to license
tidyCDISC df367fe
update wordlist & fix spelling
aclark02-arcus fb6f1fb
hide spellcheck code
aclark02-arcus 68b7499
update another spot in readme where link was getting redirected
aclark02-arcus 82f03de
Merge pull request #30 from Biogen-Inc/prep_cran_020
aclark02-arcus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,75 +1,16 @@ | ||
| ## Re-submission 2022-06-27 | ||
| This is a re-submission. In this version I have: | ||
|
|
||
| * Referenced package names using single quotes in the description field. Also, spelled out 'UI' to 'user interface'. | ||
|
|
||
| * Added appropriate `@return` roxygen comments for the following exported functions to generate `\value` statement in `.Rd` files: | ||
| - getInitializationCode.shinyDataFilter_df.Rd | ||
| - shiny_vector_filter_numeric_few.Rd | ||
| - shiny_vector_filter_numeric_many.Rd | ||
|
|
||
| #### R CMD Check | ||
| ## R CMD check results | ||
| 0 errors | 0 warnings | 1 note | ||
| ``` | ||
| checking CRAN incoming feasibility ... NOTE | ||
| Maintainer: 'Aaron Clark <clark.aaronchris@gmail.com>' | ||
|
|
||
| New submission | ||
| Found the following (possibly) invalid URLs: | ||
| URL: https://bit.ly/demo_IDEAFilter (moved to https://rinpharma.shinyapps.io/IDEAfilter/) | ||
| From: README.md | ||
| Status: 301 | ||
| Message: Moved Permanently | ||
| For content that is 'Moved Permanently', please change http to https, | ||
| add trailing slashes, or replace the old by the new URL. | ||
| ``` | ||
| This is an intentional redirect that allows the package maintainer to monitor traffic to the demo application originating from the package README | ||
|
|
||
| ## Re-submission 2022-06-24 | ||
| This is a re-submission. In this version I have: | ||
|
|
||
| * Added more details about the package functionality in the Description field of the DESCRIPTION file. | ||
|
|
||
| * Removed `@examples` section for unexported functions, which coincidentally also removed an instance where `:::` was used. | ||
|
|
||
| * Used `if(interactive())` and not `\dontrun` in `man/shiny_data_filter.Rd`'s `@examples` section since it is insufficient by itself. | ||
|
|
||
|
|
||
| #### R CMD Check | ||
| 0 errors | 0 warnings | 1 note | ||
| ``` | ||
| checking CRAN incoming feasibility ... NOTE | ||
| Maintainer: 'Aaron Clark <clark.aaronchris@gmail.com>' | ||
|
|
||
| New submission | ||
| ``` | ||
|
|
||
|
|
||
| ## Re-submission 2022-06-11 | ||
| This is a re-submission. In this version I have: | ||
|
|
||
| * Clearly identified the copyright holder in the DESCRIPTION file, and omitted the extra LICENSE file, per request, as it was not needed for AGPL-3. | ||
|
|
||
| * Reduced the size of the package to be less than 5MB. | ||
|
|
||
| #### R CMD Check | ||
| 0 errors | 0 warnings | 1 note | ||
| ``` | ||
| checking CRAN incoming feasibility ... NOTE | ||
| Maintainer: 'Aaron Clark <clark.aaronchris@gmail.com>' | ||
|
|
||
| New submission | ||
| ``` | ||
| ## Initial submission 2022-06-10 | ||
| #### R CMD Check | ||
| 0 errors | 0 warnings | 1 note | ||
|
|
||
| ``` | ||
| checking CRAN incoming feasibility ... NOTE | ||
| Maintainer: 'Aaron Clark <clark.aaronchris@gmail.com>' | ||
|
|
||
| New submission | ||
|
|
||
| License components with restrictions and base license permitting such: | ||
| AGPL-3 + file LICENSE | ||
| File 'LICENSE': | ||
| YEAR: 2020 | ||
| COPYRIGHT HOLDER: Biogen; | ||
|
|
||
| Size of tarball: 5464618 bytes | ||
| ``` | ||
| ### Downstream dependencies | ||
| ## Reverse dependency check | ||
|
|
||
| There are none. | ||
| The 1 reverse dependency was checked by running R CMD check using the development version of this package | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.