Skip to content

Convert ExtendingGenomicRanges.Rnw to .Rmd#69

Open
hsadia538 wants to merge 5 commits into
Bioconductor:develfrom
hsadia538:extGenomicRanges-rmd
Open

Convert ExtendingGenomicRanges.Rnw to .Rmd#69
hsadia538 wants to merge 5 commits into
Bioconductor:develfrom
hsadia538:extGenomicRanges-rmd

Conversation

@hsadia538

Copy link
Copy Markdown

Part of Sweave2rmd project.

  • Create a vignette in R markdown which replaces the sweave vignette.
  • Fix Spellings

Attached are the HTML vignette and Sweave for comparison here.
ExtendingGenomicRanges Rmd File
ExtendingGenomicRanges Rnw File

@hsadia538

Copy link
Copy Markdown
Author

@jwokaty please take a look.
I was unsure of the hyperlinks and whether to add them or not e.g the title links to the package website in the PDF.

@mcarlsn mcarlsn left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great conversation, I just left a few small edits. Thank you!

Comment thread vignettes/ExtendingGenomicRanges.Rmd Outdated
Comment thread vignettes/ExtendingGenomicRanges.Rmd
Comment thread vignettes/ExtendingGenomicRanges.Rmd Outdated
Comment thread vignettes/ExtendingGenomicRanges.Rmd Outdated
Comment thread vignettes/ExtendingGenomicRanges.Rmd Outdated
getSlots("GNCList")["granges"]
```

The *MutableRanges* package in svn provides other, untested examples.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MutableRanges is italicized as well as a hyperlink in the original vignette so we can change this to MutableRanges (Although as a note to @jwokaty it looks like this link goes to a removed package).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hpages Maybe this sentence should be removed since MutableRanges no longer exists?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please, thanks!

Comment thread vignettes/ExtendingGenomicRanges.Rmd Outdated
Comment thread vignettes/ExtendingGenomicRanges.Rmd Outdated
Comment thread vignettes/ExtendingGenomicRanges.Rmd Outdated
@hsadia538

Copy link
Copy Markdown
Author

I have updated and pushed. the changes

@hsadia538

Copy link
Copy Markdown
Author

Hi
@jwokaty I see this PR is still open. Do you want me to close it?

@jwokaty jwokaty changed the title sweave2rmd: Convert ExtendingGenomicRanges.Rnw to .Rmd Convert ExtendingGenomicRanges.Rnw to .Rmd Jun 22, 2023
@jwokaty jwokaty requested a review from hpages June 22, 2023 16:47
@hpages

hpages commented Jan 19, 2024

Copy link
Copy Markdown
Contributor

@jwokaty What should we do with this PR?

@jwokaty

jwokaty commented Feb 1, 2024

Copy link
Copy Markdown
Contributor

@hpages Can you review and merge it if it looks good?

@hpages

hpages commented Feb 1, 2024

Copy link
Copy Markdown
Contributor

Please remove this line. The MutableRanges package is an abandonned project that never made it to Bioconductor. Thanks!

@hpages

hpages commented Mar 25, 2024

Copy link
Copy Markdown
Contributor

@hsadia538 Are you going to be able to make that change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: PR Maintainer Review

Development

Successfully merging this pull request may close these issues.

5 participants