Merging QSDsan branch#239
Merged
yoelcortes merged 13 commits intomasterfrom May 6, 2026
Merged
Conversation
yoelcortes
approved these changes
May 6, 2026
Member
There was a problem hiding this comment.
@yalinli2, these look like bug fixes for special cases in biosteam:
- Iterate when multiple recycles are present in a single system.
- Copy state vector in case it is used in multiple places (to avoid mangling).
(happy to merge since these changes are in the dynamic simulation portion in BioSTEAM, which you and Joy are leading)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @yoelcortes @joyxyz1994 , with BioSTEAM getting stabler and the AI tools, it's now much easier to fix compatibility issues. So I'm hoping to just use the
masterbranch instead of keeping a separateqsdsanbranch.I couldn't remember what these changes were about, all tests on QSDsan/EXPOsan passed with the
masterbranch, Joy do you remember what these were about?